NeilBrown 9910f16af3
[PATCH] md: fix up some rdev rcu locking in raid5/6 ...
There is this "FIXME" comment with a typo in it!! that been annoying me for
days, so I just had to remove it.
conf->disks[i].rdev should only be accessed if
- we know we hold a reference or
- the mddev->reconfig_sem is down or
- we have a rcu_readlock
handle_stripe was referencing rdev in three places without any of these. For
the first two, get an rcu_readlock. For the last, the same access
(md_sync_acct call) is made a little later after the rdev has been claimed
under and rcu_readlock, if R5_Syncio is set. So just use that access...
However R5_Syncio isn't really needed as the 'syncing' variable contains the
same information. So use that instead.
Issues, comment, and fix are identical in raid5 and raid6.
Signed-off-by: Neil Brown <neilb@suse.de >
Signed-off-by: Andrew Morton <akpm@osdl.org >
Signed-off-by: Linus Torvalds <torvalds@osdl.org >
2006-01-06 08:34:04 -08:00
2005-12-12 08:57:44 -08:00
2005-11-28 21:00:29 +00:00
2005-12-18 16:28:24 -08:00
2006-01-05 12:20:02 -08:00
2005-11-20 21:11:31 -08:00
2006-01-05 12:21:34 -08:00
2006-01-06 08:33:59 -08:00
2006-01-06 08:34:04 -08:00
2005-11-29 16:16:41 -08:00
2005-12-14 19:03:35 -08:00
2006-01-03 13:11:06 -08:00
2005-12-15 15:11:40 -08:00
2006-01-06 08:33:26 -08:00
2005-12-16 10:52:46 -08:00
2005-11-18 22:00:17 +01:00
2005-12-12 08:57:42 -08:00
2006-01-03 11:45:28 -08:00
2005-11-28 14:42:23 -08:00
2005-12-06 19:35:11 -08:00
2006-01-03 13:11:21 -08:00
2006-01-04 16:18:08 -08:00
2006-01-06 08:34:01 -08:00
2005-11-17 16:23:43 +00:00
2005-11-17 16:23:42 +00:00
2006-01-03 15:25:45 -08:00
2005-12-12 22:31:17 -08:00
2006-01-04 16:18:08 -08:00
2006-01-06 08:33:22 -08:00
2006-01-06 08:33:56 -08:00
2005-11-22 19:39:30 -08:00
2005-11-19 22:17:55 +01:00
2006-01-06 08:33:23 -08:00
2005-12-12 08:57:45 -08:00
2006-01-06 08:33:54 -08:00
2005-12-15 02:20:15 +01:00
2006-01-03 13:11:23 -08:00
2005-12-12 08:57:43 -08:00
2006-01-04 16:18:09 -08:00
2006-01-03 13:11:21 -08:00
2005-12-21 22:56:42 +09:00
2006-01-03 13:11:21 -08:00
2006-01-06 08:33:53 -08:00
2006-01-06 08:33:59 -08:00
2006-01-06 08:33:29 -08:00
2006-01-04 16:18:08 -08:00
2005-12-12 08:57:45 -08:00
2005-12-13 02:30:04 -05:00
2005-12-12 08:57:43 -08:00
2005-11-28 14:42:23 -08:00
2006-01-06 08:33:28 -08:00
2006-01-06 08:33:33 -08:00
2006-01-06 08:33:28 -08:00
2005-12-24 15:37:00 -08:00
2006-01-06 08:33:20 -08:00
2006-01-03 13:11:15 -08:00
2005-12-01 02:20:20 -05:00
2005-12-19 23:12:09 -05:00
2006-01-06 08:33:29 -08:00
2006-01-06 08:33:58 -08:00
2006-01-06 08:33:56 -08:00
2006-01-06 08:33:38 -08:00
2006-01-03 13:10:24 -08:00
2006-01-03 13:11:05 -08:00
2006-01-04 16:18:09 -08:00
2006-01-03 12:31:30 +01:00
2005-12-22 09:17:39 -08:00
2006-01-06 08:33:32 -08:00
2006-01-03 13:10:56 -08:00
2005-12-12 08:57:42 -08:00
2005-12-20 17:33:22 -08:00
2006-01-06 08:33:27 -08:00
2005-12-19 13:54:44 -08:00
2006-01-06 08:33:29 -08:00
2006-01-03 13:10:24 -08:00
2005-11-28 18:09:44 +00:00
2006-01-03 14:06:50 -08:00
2005-11-23 08:44:05 -08:00
2006-01-03 13:11:14 -08:00
2005-12-26 00:33:41 +01:00
2006-01-06 08:33:40 -08:00
2006-01-06 08:33:43 -08:00
2006-01-04 18:44:12 -08:00
2006-01-03 13:10:58 -08:00
2005-12-12 08:57:42 -08:00
2006-01-03 13:19:13 +01:00
2006-01-03 13:19:13 +01:00
2006-01-03 13:19:13 +01:00
2006-01-03 13:11:21 -08:00
2005-11-20 00:51:33 -05:00
2006-01-04 13:51:42 -08:00
2006-01-04 18:44:12 -08:00
2006-01-03 11:45:42 -08:00
2006-01-03 13:10:24 -08:00
9910f16af3