https://source.android.com/docs/security/bulletin/2023-09-01 * tag 'ASB-2023-09-05_4.19-stable' of https://android.googlesource.com/kernel/common: Linux 4.19.294 Revert "ARM: ep93xx: fix missing-prototype warnings" Revert "MIPS: Alchemy: fix dbdma2" Linux 4.19.293 dma-buf/sw_sync: Avoid recursive lock during fence signal clk: Fix undefined reference to `clk_rate_exclusive_{get,put}' scsi: core: raid_class: Remove raid_component_add() scsi: snic: Fix double free in snic_tgt_create() irqchip/mips-gic: Don't touch vl_map if a local interrupt is not routable rtnetlink: Reject negative ifindexes in RTM_NEWLINK netfilter: nf_queue: fix socket leak sched/rt: pick_next_rt_entity(): check list_entry mmc: block: Fix in_flight[issue_type] value error x86/fpu: Set X86_FEATURE_OSXSAVE feature after enabling OSXSAVE in CR4 PCI: acpiphp: Use pci_assign_unassigned_bridge_resources() only for non-root bus media: vcodec: Fix potential array out-of-bounds in encoder queue_setup lib/clz_ctz.c: Fix __clzdi2() and __ctzdi2() for 32-bit kernels batman-adv: Fix batadv_v_ogm_aggr_send memory leak batman-adv: Fix TT global entry leak when client roamed back batman-adv: Do not get eth header before batadv_check_management_packet batman-adv: Don't increase MTU when set by user batman-adv: Trigger events for auto adjusted MTU nfsd: Fix race to FREE_STATEID and cl_revoked ibmveth: Use dcbf rather than dcbfl ipvs: fix racy memcpy in proc_do_sync_threshold ipvs: Improve robustness to the ipvs sysctl bonding: fix macvlan over alb bond support net: remove bond_slave_has_mac_rcu() net/sched: fix a qdisc modification with ambiguous command request igb: Avoid starting unnecessary workqueues dccp: annotate data-races in dccp_poll() sock: annotate data-races around prot->memory_pressure tracing: Fix memleak due to race between current_tracer and trace drm/amd/display: check TG is non-null before checking if enabled drm/amd/display: do not wait for mpc idle if tg is disabled regmap: Account for register length in SMBus I/O limits dm integrity: reduce vmalloc space footprint on 32-bit architectures dm integrity: increase RECALC_SECTORS to improve recalculate speed powerpc: Fail build if using recordmcount with binutils v2.37 powerpc: remove leftover code of old GCC version checks powerpc/32: add stack protector support fbdev: fix potential OOB read in fast_imageblit() fbdev: Fix sys_imageblit() for arbitrary image widths fbdev: Improve performance of sys_imageblit() tty: serial: fsl_lpuart: add earlycon for imx8ulp platform Revert "tty: serial: fsl_lpuart: drop earlycon entry for i.MX8QXP" MIPS: cpu-features: Use boot_cpu_type for CPU type based features MIPS: cpu-features: Enable octeon_cache by cpu_type fs: dlm: fix mismatch of plock results from userspace fs: dlm: use dlm_plock_info for do_unlock_close fs: dlm: change plock interrupted message to debug again fs: dlm: add pid to debug log dlm: replace usage of found with dedicated list iterator variable dlm: improve plock logging if interrupted PCI: acpiphp: Reassign resources on bridge if necessary net: phy: broadcom: stub c45 read/write for 54810 net: xfrm: Amend XFRMA_SEC_CTX nla_policy structure net: fix the RTO timer retransmitting skb every 1ms if linear option is enabled virtio-net: set queues after driver_ok af_unix: Fix null-ptr-deref in unix_stream_sendpage(). netfilter: set default timeout to 3 secs for sctp shutdown send and recv state test_firmware: prevent race conditions by a correct implementation of locking mmc: wbsd: fix double mmc_free_host() in wbsd_init() cifs: Release folio lock on fscache read hit. ALSA: usb-audio: Add support for Mythware XA001AU capture and playback interfaces. serial: 8250: Fix oops for port->pm on uart_change_pm() ASoC: meson: axg-tdm-formatter: fix channel slot allocation ASoC: rt5665: add missed regulator_bulk_disable net: do not allow gso_size to be set to GSO_BY_FRAGS sock: Fix misuse of sk_under_memory_pressure() i40e: fix misleading debug logs team: Fix incorrect deletion of ETH_P_8021AD protocol vid from slaves netfilter: nft_dynset: disallow object maps selftests: mirror_gre_changes: Tighten up the TTL test match xfrm: add NULL check in xfrm_update_ae_params ip_vti: fix potential slab-use-after-free in decode_session6 ip6_vti: fix slab-use-after-free in decode_session6 xfrm: fix slab-use-after-free in decode_session6 xfrm: interface: rename xfrm_interface.c to xfrm_interface_core.c net: af_key: fix sadb_x_filter validation net: xfrm: Fix xfrm_address_filter OOB read btrfs: fix BUG_ON condition in btrfs_cancel_balance powerpc/rtas_flash: allow user copy to flash block cache objects fbdev: mmp: fix value check in mmphw_probe() virtio-mmio: don't break lifecycle of vm_dev virtio-mmio: Use to_virtio_mmio_device() to simply code virtio-mmio: convert to devm_platform_ioremap_resource nfsd: Remove incorrect check in nfsd4_validate_stateid nfsd4: kill warnings on testing stateids with mismatched clientids block: fix signed int overflow in Amiga partition support mmc: sunxi: fix deferred probing mmc: bcm2835: fix deferred probing mmc: Remove dev_err() usage after platform_get_irq() mmc: tmio: move tmio_mmc_set_clock() to platform hook mmc: tmio: replace tmio_mmc_clk_stop() calls with tmio_mmc_set_clock() mmc: meson-gx: remove redundant mmc_request_done() call from irq context mmc: meson-gx: remove useless lock USB: dwc3: qcom: fix NULL-deref on suspend usb: dwc3: qcom: Add helper functions to enable,disable wake irqs irqchip/mips-gic: Use raw spinlock for gic_lock irqchip/mips-gic: Get rid of the reliance on irq_cpu_online() x86/topology: Fix erroneous smp_num_siblings on Intel Hybrid platforms powerpc/64s/radix: Fix soft dirty tracking powerpc: Move page table dump files in a dedicated subdirectory powerpc/mm: dump block address translation on book3s/32 powerpc/mm: dump segment registers on book3s/32 powerpc/mm: Move pgtable_t into platform headers powerpc/mm: move platform specific mmu-xxx.h in platform directories iio: addac: stx104: Fix race condition when converting analog-to-digital iio: addac: stx104: Fix race condition for stx104_write_raw() iio: adc: stx104: Implement and utilize register structures iio: adc: stx104: Utilize iomap interface iio: add addac subdirectory IMA: allow/fix UML builds drm/amdgpu: Fix potential fence use-after-free v2 Bluetooth: L2CAP: Fix use-after-free pcmcia: rsrc_nonstatic: Fix memory leak in nonstatic_release_resource_db() gfs2: Fix possible data races in gfs2_show_options() media: platform: mediatek: vpu: fix NULL ptr dereference media: v4l2-mem2mem: add lock to protect parameter num_rdy FS: JFS: Check for read-only mounted filesystem in txBegin FS: JFS: Fix null-ptr-deref Read in txBegin MIPS: dec: prom: Address -Warray-bounds warning fs: jfs: Fix UBSAN: array-index-out-of-bounds in dbAllocDmapLev udf: Fix uninitialized array access for some pathnames HID: add quirk for 03f0:464a HP Elite Presenter Mouse quota: fix warning in dqgrab() quota: Properly disable quotas when add_dquot_ref() fails ALSA: emu10k1: roll up loops in DSP setup code for Audigy drm/radeon: Fix integer overflow in radeon_cs_parser_init selftests: forwarding: tc_flower: Relax success criterion lib/mpi: Eliminate unused umul_ppmm definitions for MIPS Revert "posix-timers: Ensure timer ID search-loop limit is valid" UPSTREAM: media: usb: siano: Fix warning due to null work_func_t function pointer UPSTREAM: Bluetooth: L2CAP: Fix use-after-free in l2cap_sock_ready_cb UPSTREAM: net/sched: cls_route: No longer copy tcf_result on update to avoid use-after-free UPSTREAM: net/sched: cls_u32: No longer copy tcf_result on update to avoid use-after-free Linux 4.19.292 sch_netem: fix issues in netem_change() vs get_dist_table() alpha: remove __init annotation from exported page_is_ram() scsi: core: Fix possible memory leak if device_add() fails scsi: snic: Fix possible memory leak if device_add() fails scsi: 53c700: Check that command slot is not NULL scsi: storvsc: Fix handling of virtual Fibre Channel timeouts scsi: core: Fix legacy /proc parsing buffer overflow netfilter: nf_tables: report use refcount overflow netfilter: nf_tables: bogus EBUSY when deleting flowtable after flush btrfs: don't stop integrity writeback too early ibmvnic: Handle DMA unmapping of login buffs in release functions wifi: cfg80211: fix sband iftype data lookup for AP_VLAN IB/hfi1: Fix possible panic during hotplug remove drivers: net: prevent tun_build_skb() to exceed the packet size limit dccp: fix data-race around dp->dccps_mss_cache bonding: Fix incorrect deletion of ETH_P_8021AD protocol vid from slaves net/packet: annotate data-races around tp->status mISDN: Update parameter type of dsp_cmx_send() drm/nouveau/disp: Revert a NULL check inside nouveau_connector_get_modes x86: Move gds_ucode_mitigated() declaration to header x86/mm: Fix VDSO and VVAR placement on 5-level paging machines x86/cpu/amd: Enable Zenbleed fix for AMD Custom APU 0405 usb: dwc3: Properly handle processing of pending events usb-storage: alauda: Fix uninit-value in alauda_check_media() binder: fix memory leak in binder_init() iio: cros_ec: Fix the allocation size for cros_ec_command nilfs2: fix use-after-free of nilfs_root in dirtying inodes via iput radix tree test suite: fix incorrect allocation size for pthreads drm/nouveau/gr: enable memory loads on helper invocation on all channels dmaengine: pl330: Return DMA_PAUSED when transaction is paused ipv6: adjust ndisc_is_useropt() to also return true for PIO mmc: moxart: read scr register without changing byte order sparc: fix up arch_cpu_finalize_init() build breakage. UPSTREAM: net/sched: cls_fw: Fix improper refcount update leads to use-after-free Linux 4.19.291 drm/edid: fix objtool warning in drm_cvt_modes() arm64: dts: stratix10: fix incorrect I2C property for SCL signal drivers core: Use sysfs_emit and sysfs_emit_at for show(device *...) functions ARM: dts: nxp/imx6sll: fix wrong property name in usbphy node ARM: dts: imx6sll: fixup of operating points ARM: dts: imx: add usb alias ARM: dts: imx6sll: Make ssi node name same as other platforms PM: sleep: wakeirq: fix wake irq arming PM / wakeirq: support enabling wake-up irq after runtime_suspend called powerpc/mm/altmap: Fix altmap boundary check mtd: rawnand: omap_elm: Fix incorrect type in assignment test_firmware: return ENOMEM instead of ENOSPC on failed memory allocation test_firmware: fix a memory leak with reqs buffer ext2: Drop fragment support net: usbnet: Fix WARNING in usbnet_start_xmit/usb_submit_urb Bluetooth: L2CAP: Fix use-after-free in l2cap_sock_ready_cb fs/sysv: Null check to prevent null-ptr-deref bug USB: zaurus: Add ID for A-300/B-500/C-700 libceph: fix potential hang in ceph_osdc_notify() scsi: zfcp: Defer fc_rport blocking until after ADISC response tcp_metrics: fix data-race in tcpm_suck_dst() vs fastopen tcp_metrics: annotate data-races around tm->tcpm_net tcp_metrics: annotate data-races around tm->tcpm_vals[] tcp_metrics: annotate data-races around tm->tcpm_lock tcp_metrics: annotate data-races around tm->tcpm_stamp tcp_metrics: fix addr_same() helper ip6mr: Fix skb_under_panic in ip6mr_cache_report() net/sched: cls_route: No longer copy tcf_result on update to avoid use-after-free net/sched: cls_u32: No longer copy tcf_result on update to avoid use-after-free net: add missing data-race annotation for sk_ll_usec net: add missing data-race annotations around sk->sk_peek_off net: sched: cls_u32: Fix match key mis-addressing perf test uprobe_from_different_cu: Skip if there is no gcc net/mlx5e: fix return value check in mlx5e_ipsec_remove_trailer() KVM: s390: fix sthyi error handling word-at-a-time: use the same return type for has_zero regardless of endianness loop: Select I/O scheduler 'none' from inside add_disk() perf: Fix function pointer case net/sched: cls_u32: Fix reference counter leak leading to overflow ASoC: cs42l51: fix driver to properly autoload with automatic module loading net/sched: sch_qfq: account for stab overhead in qfq_enqueue net/sched: cls_fw: Fix improper refcount update leads to use-after-free drm/client: Fix memory leak in drm_client_target_cloned dm cache policy smq: ensure IO doesn't prevent cleaner policy progress ASoC: wm8904: Fill the cache for WM8904_ADC_TEST_0 register s390/dasd: fix hanging device after quiesce/resume virtio-net: fix race between set queues and probe serial: 8250_dw: Preserve original value of DLF register serial: 8250_dw: split Synopsys DesignWare 8250 common functions irq-bcm6345-l1: Do not assume a fixed block to cpu mapping tpm_tis: Explicitly check for error code btrfs: check for commit error at btrfs_attach_transaction_barrier() hwmon: (nct7802) Fix for temp6 (PECI1) processed even if PECI1 disabled staging: ks7010: potential buffer overflow in ks_wlan_set_encode_ext() Documentation: security-bugs.rst: clarify CVE handling Documentation: security-bugs.rst: update preferences when dealing with the linux-distros group usb: xhci-mtk: set the dma max_seg_size USB: quirks: add quirk for Focusrite Scarlett usb: ohci-at91: Fix the unhandle interrupt when resume usb: dwc3: don't reset device side if dwc3 was configured as host-only usb: dwc3: pci: skip BYT GPIO lookup table for hardwired phy Revert "usb: dwc3: core: Enable AutoRetry feature in the controller" can: gs_usb: gs_can_close(): add missing set of CAN state to CAN_STATE_STOPPED USB: serial: simple: sort driver entries USB: serial: simple: add Kaufmann RKS+CAN VCP USB: serial: option: add Quectel EC200A module support USB: serial: option: support Quectel EM060K_128 tracing: Fix warning in trace_buffered_event_disable() ring-buffer: Fix wrong stat of cpu_buffer->read ata: pata_ns87415: mark ns87560_tf_read static dm raid: fix missing reconfig_mutex unlock in raid_ctr() error paths block: Fix a source code comment in include/uapi/linux/blkzoned.h ASoC: fsl_spdif: Silence output on stop drm/msm: Fix IS_ERR_OR_NULL() vs NULL check in a5xx_submit_in_rb() RDMA/mlx4: Make check for invalid flags stricter benet: fix return value check in be_lancer_xmit_workarounds() net/sched: mqprio: Add length check for TCA_MQPRIO_{MAX/MIN}_RATE64 net/sched: mqprio: add extack to mqprio_parse_nlattr() net/sched: mqprio: refactor nlattr parsing to a separate function platform/x86: msi-laptop: Fix rfkill out-of-sync on MSI Wind U100 team: reset team's flags when down link is P2P device bonding: reset bond's flags when down link is P2P device tcp: Reduce chance of collisions in inet6_hashfn(). ipv6 addrconf: fix bug where deleting a mngtmpaddr can create a new temporary address ethernet: atheros: fix return value check in atl1e_tso_csum() phy: hisilicon: Fix an out of bounds check in hisi_inno_phy_probe() i40e: Fix an NULL vs IS_ERR() bug for debugfs_create_dir() ext4: fix to check return value of freeze_bdev() in ext4_shutdown() scsi: qla2xxx: Array index may go out of bound scsi: qla2xxx: Fix inconsistent format argument type in qla_os.c ftrace: Fix possible warning on checking all pages used in ftrace_process_locs() ftrace: Store the order of pages allocated in ftrace_page ftrace: Check if pages were allocated before calling free_pages() ftrace: Add information on number of page groups allocated fs: dlm: interrupt posix locks only when process is killed dlm: rearrange async condition return dlm: cleanup plock_op vs plock_xop PCI/ASPM: Avoid link retraining race PCI/ASPM: Factor out pcie_wait_for_retrain() PCI/ASPM: Return 0 or -ETIMEDOUT from pcie_retrain_link() PCI: Rework pcie_retrain_link() wait loop ext4: Fix reusing stale buffer heads from last failed mounting ext4: rename journal_dev to s_journal_dev inside ext4_sb_info btrfs: fix extent buffer leak after tree mod log failure at split_node() bcache: Fix __bch_btree_node_alloc to make the failure behavior consistent bcache: remove 'int n' from parameter list of bch_bucket_alloc_set() bcache: use MAX_CACHES_PER_SET instead of magic number 8 in __bch_bucket_alloc_set gpio: tps68470: Make tps68470_gpio_output() always set the initial value tracing/histograms: Return an error if we fail to add histogram to hist_vars list tcp: annotate data-races around fastopenq.max_qlen tcp: annotate data-races around tp->notsent_lowat tcp: annotate data-races around rskq_defer_accept tcp: annotate data-races around tp->linger2 net: Replace the limit of TCP_LINGER2 with TCP_FIN_TIMEOUT_MAX netfilter: nf_tables: can't schedule in nft_chain_validate netfilter: nf_tables: fix spurious set element insertion failure llc: Don't drop packet from non-root netns. fbdev: au1200fb: Fix missing IRQ check in au1200fb_drv_probe Revert "tcp: avoid the lookup process failing to get sk in ehash table" net:ipv6: check return value of pskb_trim() net: ethernet: ti: cpsw_ale: Fix cpsw_ale_get_field()/cpsw_ale_set_field() pinctrl: amd: Use amd_pinconf_set() for all config options fbdev: imxfb: warn about invalid left/right margin spi: bcm63xx: fix max prepend length igb: Fix igb_down hung on surprise removal wifi: iwlwifi: mvm: avoid baid size integer overflow wifi: wext-core: Fix -Wstringop-overflow warning in ioctl_standard_iw_point() bpf: Address KCSAN report on bpf_lru_list sched/fair: Don't balance task to its current running CPU posix-timers: Ensure timer ID search-loop limit is valid md/raid10: prevent soft lockup while flush writes md: fix data corruption for raid456 when reshape restart while grow up nbd: Add the maximum limit of allocated index in nbd_dev_add debugobjects: Recheck debug_objects_enabled before reporting ext4: correct inline offset when handling xattrs in inode body can: bcm: Fix UAF in bcm_proc_show() fuse: revalidate: don't invalidate if interrupted perf probe: Add test for regression introduced by switch to die_get_decl_file() tracing/histograms: Add histograms to hist_vars if they have referenced variables drm/atomic: Fix potential use-after-free in nonblocking commits scsi: qla2xxx: Pointer may be dereferenced scsi: qla2xxx: Check valid rport returned by fc_bsg_to_rport() scsi: qla2xxx: Fix potential NULL pointer dereference scsi: qla2xxx: Wait for io return on terminate rport xtensa: ISS: fix call to split_if_spec ring-buffer: Fix deadloop issue on reading trace_pipe tty: serial: samsung_tty: Fix a memory leak in s3c24xx_serial_getclk() when iterating clk tty: serial: samsung_tty: Fix a memory leak in s3c24xx_serial_getclk() in case of error Revert "8250: add support for ASIX devices with a FIFO bug" meson saradc: fix clock divider mask length ceph: don't let check_caps skip sending responses for revoke msgs hwrng: imx-rngc - fix the timeout for init and self check serial: atmel: don't enable IRQs prematurely fs: dlm: return positive pid value for F_GETLK md/raid0: add discard support for the 'original' layout misc: pci_endpoint_test: Re-init completion for every test misc: pci_endpoint_test: Free IRQs before removing the device PCI: rockchip: Use u32 variable to access 32-bit registers PCI: rockchip: Fix legacy IRQ generation for RK3399 PCIe endpoint core PCI: rockchip: Add poll and timeout to wait for PHY PLLs to be locked PCI: rockchip: Write PCI Device ID to correct register PCI: rockchip: Assert PCI Configuration Enable bit after probe PCI: qcom: Disable write access to read only registers for IP v2.3.3 PCI: Add function 1 DMA alias quirk for Marvell 88SE9235 PCI/PM: Avoid putting EloPOS E2/S2/H2 PCIe Ports in D3cold jfs: jfs_dmap: Validate db_l2nbperpage while mounting ext4: only update i_reserved_data_blocks on successful block allocation ext4: fix wrong unit use in ext4_mb_clear_bb perf intel-pt: Fix CYC timestamps after standalone CBR SUNRPC: Fix UAF in svc_tcp_listen_data_ready() net: bcmgenet: Ensure MDIO unregistration has clocks enabled tpm: tpm_vtpm_proxy: fix a race condition in /dev/vtpmx creation pinctrl: amd: Only use special debounce behavior for GPIO 0 pinctrl: amd: Detect internal GPIO0 debounce handling pinctrl: amd: Fix mistake in handling clearing pins at startup net/sched: make psched_mtu() RTNL-less safe wifi: airo: avoid uninitialized warning in airo_get_rate() ipv6/addrconf: fix a potential refcount underflow for idev NTB: ntb_tool: Add check for devm_kcalloc NTB: ntb_transport: fix possible memory leak while device_register() fails ntb: intel: Fix error handling in intel_ntb_pci_driver_init() NTB: amd: Fix error handling in amd_ntb_pci_driver_init() ntb: idt: Fix error handling in idt_pci_driver_init() udp6: fix udp6_ehashfn() typo icmp6: Fix null-ptr-deref of ip6_null_entry->rt6i_idev in icmp6_dev(). vrf: Increment Icmp6InMsgs on the original netdev net: mvneta: fix txq_map in case of txq_number==1 workqueue: clean up WORK_* constant types, clarify masking net: lan743x: Don't sleep in atomic context netfilter: nf_tables: prevent OOB access in nft_byteorder_eval netfilter: conntrack: Avoid nf_ct_helper_hash uses after free netfilter: nf_tables: fix scheduling-while-atomic splat netfilter: nf_tables: unbind non-anonymous set if rule construction fails netfilter: nf_tables: reject unbound anonymous set before commit phase netfilter: nf_tables: add NFT_TRANS_PREPARE_ERROR to deal with bound set/chain netfilter: nf_tables: incorrect error path handling with NFT_MSG_NEWRULE netfilter: nf_tables: use net_generic infra for transaction data netfilter: add helper function to set up the nfnetlink header and use it netfilter: nftables: add helper function to set the base sequence number netfilter: nf_tables: add rescheduling points during loop detection walks netfilter: nf_tables: fix nat hook table deletion spi: spi-fsl-spi: allow changing bits_per_word while CS is still active spi: spi-fsl-spi: relax message sanity checking a little spi: spi-fsl-spi: remove always-true conditional in fsl_spi_do_one_msg ARM: orion5x: fix d2net gpio initialization btrfs: fix race when deleting quota root from the dirty cow roots list jffs2: reduce stack usage in jffs2_build_xattr_subsystem() integrity: Fix possible multiple allocation in integrity_inode_get() bcache: Remove unnecessary NULL point check in node allocations mmc: core: disable TRIM on Micron MTFC4GACAJCN-1M mmc: core: disable TRIM on Kingston EMMC04G-M627 NFSD: add encoding of op_recall flag for write delegation ALSA: jack: Fix mutex call in snd_jack_report() i2c: xiic: Don't try to handle more interrupt events after error i2c: xiic: Defer xiic_wakeup() and __xiic_start_xfer() in xiic_process() sh: dma: Fix DMA channel offset calculation net/sched: act_pedit: Add size check for TCA_PEDIT_PARMS_EX tcp: annotate data races in __tcp_oow_rate_limited() net: bridge: keep ports without IFF_UNICAST_FLT in BR_PROMISC mode powerpc: allow PPC_EARLY_DEBUG_CPM only when SERIAL_CPM=y f2fs: fix error path handling in truncate_dnode() mailbox: ti-msgmgr: Fill non-message tx data fields with 0x0 spi: bcm-qspi: return error if neither hif_mspi nor mspi is available Add MODULE_FIRMWARE() for FIRMWARE_TG357766. sctp: fix potential deadlock on &net->sctp.addr_wq_lock rtc: st-lpc: Release some resources in st_rtc_probe() in case of error mfd: stmpe: Only disable the regulators if they are enabled mfd: intel-lpss: Add missing check for platform_get_resource KVM: s390: fix KVM_S390_GET_CMMA_BITS for GFNs in memslot holes mfd: rt5033: Drop rt5033-battery sub-device usb: phy: phy-tahvo: fix memory leak in tahvo_usb_probe() extcon: Fix kernel doc of property capability fields to avoid warnings extcon: Fix kernel doc of property fields to avoid warnings media: usb: siano: Fix warning due to null work_func_t function pointer media: videodev2.h: Fix struct v4l2_input tuner index comment media: usb: Check az6007_read() return value sh: j2: Use ioremap() to translate device tree address into kernel memory w1: fix loop in w1_fini() block: change all __u32 annotations to __be32 in affs_hardblocks.h USB: serial: option: add LARA-R6 01B PIDs ARC: define ASM_NL and __ALIGN(_STR) outside #ifdef __ASSEMBLY__ guard ARCv2: entry: rewrite to enable use of double load/stores LDD/STD ARCv2: entry: avoid a branch ARCv2: entry: push out the Z flag unclobber from common EXCEPTION_PROLOGUE ARCv2: entry: comments about hardware auto-save on taken interrupts modpost: fix section mismatch message for R_ARM_{PC24,CALL,JUMP24} modpost: fix section mismatch message for R_ARM_ABS32 crypto: nx - fix build warnings when DEBUG_FS is not enabled hwrng: virtio - Fix race on data_avail and actual data hwrng: virtio - always add a pending request hwrng: virtio - don't waste entropy hwrng: virtio - don't wait on cleanup hwrng: virtio - add an internal buffer pinctrl: at91-pio4: check return value of devm_kasprintf() perf dwarf-aux: Fix off-by-one in die_get_varname() pinctrl: cherryview: Return correct value if pin in push-pull mode PCI: Add pci_clear_master() stub for non-CONFIG_PCI scsi: 3w-xxxx: Add error handling for initialization failure in tw_probe() ALSA: ac97: Fix possible NULL dereference in snd_ac97_mixer drm/radeon: fix possible division-by-zero errors fbdev: omapfb: lcd_mipid: Fix an error handling path in mipid_spi_probe() arm64: dts: renesas: ulcb-kf: Remove flow control for SCIF1 IB/hfi1: Fix sdma.h tx->num_descs off-by-one errors soc/fsl/qe: fix usb.c build errors ASoC: es8316: Increment max value for ALC Capture Target Volume control ARM: ep93xx: fix missing-prototype warnings drm/panel: simple: fix active size for Ampire AM-480272H3TMQW-T01H Input: adxl34x - do not hardcode interrupt trigger type ARM: dts: BCM5301X: Drop "clock-names" from the SPI node Input: drv260x - sleep between polling GO bit radeon: avoid double free in ci_dpm_init() netlink: Add __sock_i_ino() for __netlink_diag_dump(). ipvlan: Fix return value of ipvlan_queue_xmit() netfilter: nf_conntrack_sip: fix the ct_sip_parse_numerical_param() return value. lib/ts_bm: reset initial match offset for every block of text gtp: Fix use-after-free in __gtp_encap_destroy(). netlink: do not hard code device address lenth in fdb dumps netlink: fix potential deadlock in netlink_set_err() wifi: ath9k: convert msecs to jiffies where needed wifi: ath9k: Fix possible stall on ath9k_txq_list_has_key() memstick r592: make memstick_debug_get_tpc_name() static kexec: fix a memory leak in crash_shrink_memory() watchdog/perf: more properly prevent false positives with turbo modes watchdog/perf: define dummy watchdog_update_hrtimer_threshold() on correct config wifi: rsi: Do not set MMC_PM_KEEP_POWER in shutdown wifi: ath9k: don't allow to overwrite ENDPOINT0 attributes wifi: ray_cs: Fix an error handling path in ray_probe() wifi: ray_cs: Drop useless status variable in parse_addr() wifi: ray_cs: Utilize strnlen() in parse_addr() wifi: wl3501_cs: Fix an error handling path in wl3501_probe() wl3501_cs: use eth_hw_addr_set() net: create netdev->dev_addr assignment helpers wl3501_cs: Fix misspelling and provide missing documentation wl3501_cs: Remove unnecessary NULL check wl3501_cs: Fix a bunch of formatting issues related to function docs wifi: atmel: Fix an error handling path in atmel_probe() wifi: orinoco: Fix an error handling path in orinoco_cs_probe() wifi: orinoco: Fix an error handling path in spectrum_cs_probe() nfc: llcp: fix possible use of uninitialized variable in nfc_llcp_send_connect() nfc: constify several pointers to u8, char and sk_buff wifi: mwifiex: Fix the size of a memory allocation in mwifiex_ret_802_11_scan() samples/bpf: Fix buffer overflow in tcp_basertt wifi: ath9k: avoid referencing uninit memory in ath9k_wmi_ctrl_rx wifi: ath9k: fix AR9003 mac hardware hang check register offset calculation evm: Complete description of evm_inode_setattr() ARM: 9303/1: kprobes: avoid missing-declaration warnings PM: domains: fix integer overflow issues in genpd_parse_state() clocksource/drivers/cadence-ttc: Fix memory leak in ttc_timer_probe clocksource/drivers/cadence-ttc: Use ttc driver as platform driver clocksource/drivers: Unify the names to timer-* format irqchip/jcore-aic: Fix missing allocation of IRQ descriptors irqchip/jcore-aic: Kill use of irq_create_strict_mappings() md/raid10: fix io loss while replacement replace rdev md/raid10: fix wrong setting of max_corr_read_errors md/raid10: fix overflow of md/safe_mode_delay md/raid10: check slab-out-of-bounds in md_bitmap_get_counter treewide: Remove uninitialized_var() usage drm/amdgpu: Validate VM ioctl flags. scripts/tags.sh: Resolve gtags empty index generation drm/edid: Fix uninitialized variable in drm_cvt_modes() fbdev: imsttfb: Fix use after free bug in imsttfb_probe video: imsttfb: check for ioremap() failures x86/smp: Use dedicated cache-line for mwait_play_dead() gfs2: Don't deref jdesc in evict Linux 4.19.290 x86: fix backwards merge of GDS/SRSO bit xen/netback: Fix buffer overrun triggered by unusual packet Documentation/x86: Fix backwards on/off logic about YMM support x86/xen: Fix secondary processors' FPU initialization KVM: Add GDS_NO support to KVM x86/speculation: Add Kconfig option for GDS x86/speculation: Add force option to GDS mitigation x86/speculation: Add Gather Data Sampling mitigation x86/fpu: Move FPU initialization into arch_cpu_finalize_init() x86/fpu: Mark init functions __init x86/fpu: Remove cpuinfo argument from init functions init, x86: Move mem_encrypt_init() into arch_cpu_finalize_init() init: Invoke arch_cpu_finalize_init() earlier init: Remove check_bugs() leftovers um/cpu: Switch to arch_cpu_finalize_init() sparc/cpu: Switch to arch_cpu_finalize_init() sh/cpu: Switch to arch_cpu_finalize_init() mips/cpu: Switch to arch_cpu_finalize_init() m68k/cpu: Switch to arch_cpu_finalize_init() ia64/cpu: Switch to arch_cpu_finalize_init() ARM: cpu: Switch to arch_cpu_finalize_init() x86/cpu: Switch to arch_cpu_finalize_init() init: Provide arch_cpu_finalize_init() Conflicts: drivers/mmc/core/block.c drivers/mmc/host/sdhci-msm.c drivers/usb/dwc3/core.c drivers/usb/dwc3/gadget.c Change-Id: Id2f4d5c8067f8e5eda39c0eaa5e59d54a394b4c7
1047 lines
29 KiB
C
1047 lines
29 KiB
C
/*
|
|
* linux/mm/swap.c
|
|
*
|
|
* Copyright (C) 1991, 1992, 1993, 1994 Linus Torvalds
|
|
*/
|
|
|
|
/*
|
|
* This file contains the default values for the operation of the
|
|
* Linux VM subsystem. Fine-tuning documentation can be found in
|
|
* Documentation/sysctl/vm.txt.
|
|
* Started 18.12.91
|
|
* Swap aging added 23.2.95, Stephen Tweedie.
|
|
* Buffermem limits added 12.3.98, Rik van Riel.
|
|
*/
|
|
|
|
#include <linux/mm.h>
|
|
#include <linux/sched.h>
|
|
#include <linux/kernel_stat.h>
|
|
#include <linux/swap.h>
|
|
#include <linux/mman.h>
|
|
#include <linux/pagemap.h>
|
|
#include <linux/pagevec.h>
|
|
#include <linux/init.h>
|
|
#include <linux/export.h>
|
|
#include <linux/mm_inline.h>
|
|
#include <linux/percpu_counter.h>
|
|
#include <linux/memremap.h>
|
|
#include <linux/percpu.h>
|
|
#include <linux/cpu.h>
|
|
#include <linux/notifier.h>
|
|
#include <linux/backing-dev.h>
|
|
#include <linux/memremap.h>
|
|
#include <linux/memcontrol.h>
|
|
#include <linux/gfp.h>
|
|
#include <linux/uio.h>
|
|
#include <linux/hugetlb.h>
|
|
#include <linux/page_idle.h>
|
|
|
|
#include "internal.h"
|
|
|
|
#define CREATE_TRACE_POINTS
|
|
#include <trace/events/pagemap.h>
|
|
|
|
/* How many pages do we try to swap or page in/out together? */
|
|
int page_cluster;
|
|
|
|
static DEFINE_PER_CPU(struct pagevec, lru_add_pvec);
|
|
static DEFINE_PER_CPU(struct pagevec, lru_rotate_pvecs);
|
|
static DEFINE_PER_CPU(struct pagevec, lru_deactivate_file_pvecs);
|
|
static DEFINE_PER_CPU(struct pagevec, lru_lazyfree_pvecs);
|
|
#ifdef CONFIG_SMP
|
|
static DEFINE_PER_CPU(struct pagevec, activate_page_pvecs);
|
|
#endif
|
|
|
|
/*
|
|
* This path almost never happens for VM activity - pages are normally
|
|
* freed via pagevecs. But it gets used by networking.
|
|
*/
|
|
static void __page_cache_release(struct page *page)
|
|
{
|
|
if (PageLRU(page)) {
|
|
struct zone *zone = page_zone(page);
|
|
struct lruvec *lruvec;
|
|
unsigned long flags;
|
|
|
|
spin_lock_irqsave(zone_lru_lock(zone), flags);
|
|
lruvec = mem_cgroup_page_lruvec(page, zone->zone_pgdat);
|
|
VM_BUG_ON_PAGE(!PageLRU(page), page);
|
|
__ClearPageLRU(page);
|
|
del_page_from_lru_list(page, lruvec, page_off_lru(page));
|
|
spin_unlock_irqrestore(zone_lru_lock(zone), flags);
|
|
}
|
|
__ClearPageWaiters(page);
|
|
mem_cgroup_uncharge(page);
|
|
}
|
|
|
|
static void __put_single_page(struct page *page)
|
|
{
|
|
__page_cache_release(page);
|
|
free_unref_page(page);
|
|
}
|
|
|
|
static void __put_compound_page(struct page *page)
|
|
{
|
|
compound_page_dtor *dtor;
|
|
|
|
/*
|
|
* __page_cache_release() is supposed to be called for thp, not for
|
|
* hugetlb. This is because hugetlb page does never have PageLRU set
|
|
* (it's never listed to any LRU lists) and no memcg routines should
|
|
* be called for hugetlb (it has a separate hugetlb_cgroup.)
|
|
*/
|
|
if (!PageHuge(page))
|
|
__page_cache_release(page);
|
|
dtor = get_compound_page_dtor(page);
|
|
(*dtor)(page);
|
|
}
|
|
|
|
void __put_page(struct page *page)
|
|
{
|
|
if (is_zone_device_page(page)) {
|
|
put_dev_pagemap(page->pgmap);
|
|
|
|
/*
|
|
* The page belongs to the device that created pgmap. Do
|
|
* not return it to page allocator.
|
|
*/
|
|
return;
|
|
}
|
|
|
|
if (unlikely(PageCompound(page)))
|
|
__put_compound_page(page);
|
|
else
|
|
__put_single_page(page);
|
|
}
|
|
EXPORT_SYMBOL(__put_page);
|
|
|
|
/**
|
|
* put_pages_list() - release a list of pages
|
|
* @pages: list of pages threaded on page->lru
|
|
*
|
|
* Release a list of pages which are strung together on page.lru. Currently
|
|
* used by read_cache_pages() and related error recovery code.
|
|
*/
|
|
void put_pages_list(struct list_head *pages)
|
|
{
|
|
while (!list_empty(pages)) {
|
|
struct page *victim;
|
|
|
|
victim = list_entry(pages->prev, struct page, lru);
|
|
list_del(&victim->lru);
|
|
put_page(victim);
|
|
}
|
|
}
|
|
EXPORT_SYMBOL(put_pages_list);
|
|
|
|
/*
|
|
* get_kernel_pages() - pin kernel pages in memory
|
|
* @kiov: An array of struct kvec structures
|
|
* @nr_segs: number of segments to pin
|
|
* @write: pinning for read/write, currently ignored
|
|
* @pages: array that receives pointers to the pages pinned.
|
|
* Should be at least nr_segs long.
|
|
*
|
|
* Returns number of pages pinned. This may be fewer than the number
|
|
* requested. If nr_pages is 0 or negative, returns 0. If no pages
|
|
* were pinned, returns -errno. Each page returned must be released
|
|
* with a put_page() call when it is finished with.
|
|
*/
|
|
int get_kernel_pages(const struct kvec *kiov, int nr_segs, int write,
|
|
struct page **pages)
|
|
{
|
|
int seg;
|
|
|
|
for (seg = 0; seg < nr_segs; seg++) {
|
|
if (WARN_ON(kiov[seg].iov_len != PAGE_SIZE))
|
|
return seg;
|
|
|
|
pages[seg] = kmap_to_page(kiov[seg].iov_base);
|
|
get_page(pages[seg]);
|
|
}
|
|
|
|
return seg;
|
|
}
|
|
EXPORT_SYMBOL_GPL(get_kernel_pages);
|
|
|
|
/*
|
|
* get_kernel_page() - pin a kernel page in memory
|
|
* @start: starting kernel address
|
|
* @write: pinning for read/write, currently ignored
|
|
* @pages: array that receives pointer to the page pinned.
|
|
* Must be at least nr_segs long.
|
|
*
|
|
* Returns 1 if page is pinned. If the page was not pinned, returns
|
|
* -errno. The page returned must be released with a put_page() call
|
|
* when it is finished with.
|
|
*/
|
|
int get_kernel_page(unsigned long start, int write, struct page **pages)
|
|
{
|
|
const struct kvec kiov = {
|
|
.iov_base = (void *)start,
|
|
.iov_len = PAGE_SIZE
|
|
};
|
|
|
|
return get_kernel_pages(&kiov, 1, write, pages);
|
|
}
|
|
EXPORT_SYMBOL_GPL(get_kernel_page);
|
|
|
|
static void pagevec_lru_move_fn(struct pagevec *pvec,
|
|
void (*move_fn)(struct page *page, struct lruvec *lruvec, void *arg),
|
|
void *arg)
|
|
{
|
|
int i;
|
|
struct pglist_data *pgdat = NULL;
|
|
struct lruvec *lruvec;
|
|
unsigned long flags = 0;
|
|
|
|
for (i = 0; i < pagevec_count(pvec); i++) {
|
|
struct page *page = pvec->pages[i];
|
|
struct pglist_data *pagepgdat = page_pgdat(page);
|
|
|
|
if (pagepgdat != pgdat) {
|
|
if (pgdat)
|
|
spin_unlock_irqrestore(&pgdat->lru_lock, flags);
|
|
pgdat = pagepgdat;
|
|
spin_lock_irqsave(&pgdat->lru_lock, flags);
|
|
}
|
|
|
|
lruvec = mem_cgroup_page_lruvec(page, pgdat);
|
|
(*move_fn)(page, lruvec, arg);
|
|
}
|
|
if (pgdat)
|
|
spin_unlock_irqrestore(&pgdat->lru_lock, flags);
|
|
release_pages(pvec->pages, pvec->nr);
|
|
pagevec_reinit(pvec);
|
|
}
|
|
|
|
static void pagevec_move_tail_fn(struct page *page, struct lruvec *lruvec,
|
|
void *arg)
|
|
{
|
|
int *pgmoved = arg;
|
|
|
|
if (PageLRU(page) && !PageUnevictable(page)) {
|
|
del_page_from_lru_list(page, lruvec, page_lru(page));
|
|
ClearPageActive(page);
|
|
add_page_to_lru_list_tail(page, lruvec, page_lru(page));
|
|
(*pgmoved)++;
|
|
}
|
|
}
|
|
|
|
/*
|
|
* pagevec_move_tail() must be called with IRQ disabled.
|
|
* Otherwise this may cause nasty races.
|
|
*/
|
|
static void pagevec_move_tail(struct pagevec *pvec)
|
|
{
|
|
int pgmoved = 0;
|
|
|
|
pagevec_lru_move_fn(pvec, pagevec_move_tail_fn, &pgmoved);
|
|
__count_vm_events(PGROTATED, pgmoved);
|
|
}
|
|
|
|
/*
|
|
* Writeback is about to end against a page which has been marked for immediate
|
|
* reclaim. If it still appears to be reclaimable, move it to the tail of the
|
|
* inactive list.
|
|
*/
|
|
void rotate_reclaimable_page(struct page *page)
|
|
{
|
|
if (!PageLocked(page) && !PageDirty(page) &&
|
|
!PageUnevictable(page) && PageLRU(page)) {
|
|
struct pagevec *pvec;
|
|
unsigned long flags;
|
|
|
|
get_page(page);
|
|
local_irq_save(flags);
|
|
pvec = this_cpu_ptr(&lru_rotate_pvecs);
|
|
if (!pagevec_add(pvec, page) || PageCompound(page))
|
|
pagevec_move_tail(pvec);
|
|
local_irq_restore(flags);
|
|
}
|
|
}
|
|
|
|
static void update_page_reclaim_stat(struct lruvec *lruvec,
|
|
int file, int rotated)
|
|
{
|
|
struct zone_reclaim_stat *reclaim_stat = &lruvec->reclaim_stat;
|
|
|
|
reclaim_stat->recent_scanned[file]++;
|
|
if (rotated)
|
|
reclaim_stat->recent_rotated[file]++;
|
|
}
|
|
|
|
static void __activate_page(struct page *page, struct lruvec *lruvec,
|
|
void *arg)
|
|
{
|
|
if (PageLRU(page) && !PageActive(page) && !PageUnevictable(page)) {
|
|
int file = page_is_file_cache(page);
|
|
int lru = page_lru_base_type(page);
|
|
|
|
del_page_from_lru_list(page, lruvec, lru);
|
|
SetPageActive(page);
|
|
lru += LRU_ACTIVE;
|
|
add_page_to_lru_list(page, lruvec, lru);
|
|
trace_mm_lru_activate(page);
|
|
|
|
__count_vm_event(PGACTIVATE);
|
|
update_page_reclaim_stat(lruvec, file, 1);
|
|
}
|
|
}
|
|
|
|
#ifdef CONFIG_SMP
|
|
static void activate_page_drain(int cpu)
|
|
{
|
|
struct pagevec *pvec = &per_cpu(activate_page_pvecs, cpu);
|
|
|
|
if (pagevec_count(pvec))
|
|
pagevec_lru_move_fn(pvec, __activate_page, NULL);
|
|
}
|
|
|
|
static bool need_activate_page_drain(int cpu)
|
|
{
|
|
return pagevec_count(&per_cpu(activate_page_pvecs, cpu)) != 0;
|
|
}
|
|
|
|
void activate_page(struct page *page)
|
|
{
|
|
page = compound_head(page);
|
|
if (PageLRU(page) && !PageActive(page) && !PageUnevictable(page)) {
|
|
struct pagevec *pvec = &get_cpu_var(activate_page_pvecs);
|
|
|
|
get_page(page);
|
|
if (!pagevec_add(pvec, page) || PageCompound(page))
|
|
pagevec_lru_move_fn(pvec, __activate_page, NULL);
|
|
put_cpu_var(activate_page_pvecs);
|
|
}
|
|
}
|
|
|
|
#else
|
|
static inline void activate_page_drain(int cpu)
|
|
{
|
|
}
|
|
|
|
void activate_page(struct page *page)
|
|
{
|
|
struct zone *zone = page_zone(page);
|
|
|
|
page = compound_head(page);
|
|
spin_lock_irq(zone_lru_lock(zone));
|
|
__activate_page(page, mem_cgroup_page_lruvec(page, zone->zone_pgdat), NULL);
|
|
spin_unlock_irq(zone_lru_lock(zone));
|
|
}
|
|
#endif
|
|
|
|
static void __lru_cache_activate_page(struct page *page)
|
|
{
|
|
struct pagevec *pvec = &get_cpu_var(lru_add_pvec);
|
|
int i;
|
|
|
|
/*
|
|
* Search backwards on the optimistic assumption that the page being
|
|
* activated has just been added to this pagevec. Note that only
|
|
* the local pagevec is examined as a !PageLRU page could be in the
|
|
* process of being released, reclaimed, migrated or on a remote
|
|
* pagevec that is currently being drained. Furthermore, marking
|
|
* a remote pagevec's page PageActive potentially hits a race where
|
|
* a page is marked PageActive just after it is added to the inactive
|
|
* list causing accounting errors and BUG_ON checks to trigger.
|
|
*/
|
|
for (i = pagevec_count(pvec) - 1; i >= 0; i--) {
|
|
struct page *pagevec_page = pvec->pages[i];
|
|
|
|
if (pagevec_page == page) {
|
|
SetPageActive(page);
|
|
break;
|
|
}
|
|
}
|
|
|
|
put_cpu_var(lru_add_pvec);
|
|
}
|
|
|
|
/*
|
|
* Mark a page as having seen activity.
|
|
*
|
|
* inactive,unreferenced -> inactive,referenced
|
|
* inactive,referenced -> active,unreferenced
|
|
* active,unreferenced -> active,referenced
|
|
*
|
|
* When a newly allocated page is not yet visible, so safe for non-atomic ops,
|
|
* __SetPageReferenced(page) may be substituted for mark_page_accessed(page).
|
|
*/
|
|
void mark_page_accessed(struct page *page)
|
|
{
|
|
page = compound_head(page);
|
|
if (!PageActive(page) && !PageUnevictable(page) &&
|
|
PageReferenced(page)) {
|
|
|
|
/*
|
|
* If the page is on the LRU, queue it for activation via
|
|
* activate_page_pvecs. Otherwise, assume the page is on a
|
|
* pagevec, mark it active and it'll be moved to the active
|
|
* LRU on the next drain.
|
|
*/
|
|
if (PageLRU(page))
|
|
activate_page(page);
|
|
else
|
|
__lru_cache_activate_page(page);
|
|
ClearPageReferenced(page);
|
|
if (page_is_file_cache(page))
|
|
workingset_activation(page);
|
|
} else if (!PageReferenced(page)) {
|
|
SetPageReferenced(page);
|
|
}
|
|
if (page_is_idle(page))
|
|
clear_page_idle(page);
|
|
}
|
|
EXPORT_SYMBOL(mark_page_accessed);
|
|
|
|
static void __lru_cache_add(struct page *page)
|
|
{
|
|
struct pagevec *pvec = &get_cpu_var(lru_add_pvec);
|
|
|
|
get_page(page);
|
|
if (!pagevec_add(pvec, page) || PageCompound(page))
|
|
__pagevec_lru_add(pvec);
|
|
put_cpu_var(lru_add_pvec);
|
|
}
|
|
|
|
/**
|
|
* lru_cache_add_anon - add a page to the page lists
|
|
* @page: the page to add
|
|
*/
|
|
void lru_cache_add_anon(struct page *page)
|
|
{
|
|
if (PageActive(page))
|
|
ClearPageActive(page);
|
|
__lru_cache_add(page);
|
|
}
|
|
|
|
void lru_cache_add_file(struct page *page)
|
|
{
|
|
if (PageActive(page))
|
|
ClearPageActive(page);
|
|
__lru_cache_add(page);
|
|
}
|
|
EXPORT_SYMBOL(lru_cache_add_file);
|
|
|
|
/**
|
|
* lru_cache_add - add a page to a page list
|
|
* @page: the page to be added to the LRU.
|
|
*
|
|
* Queue the page for addition to the LRU via pagevec. The decision on whether
|
|
* to add the page to the [in]active [file|anon] list is deferred until the
|
|
* pagevec is drained. This gives a chance for the caller of lru_cache_add()
|
|
* have the page added to the active list using mark_page_accessed().
|
|
*/
|
|
void lru_cache_add(struct page *page)
|
|
{
|
|
VM_BUG_ON_PAGE(PageActive(page) && PageUnevictable(page), page);
|
|
VM_BUG_ON_PAGE(PageLRU(page), page);
|
|
__lru_cache_add(page);
|
|
}
|
|
|
|
/**
|
|
* lru_cache_add_active_or_unevictable
|
|
* @page: the page to be added to LRU
|
|
* @vma: vma in which page is mapped for determining reclaimability
|
|
*
|
|
* Place @page on the active or unevictable LRU list, depending on its
|
|
* evictability. Note that if the page is not evictable, it goes
|
|
* directly back onto it's zone's unevictable list, it does NOT use a
|
|
* per cpu pagevec.
|
|
*/
|
|
void __lru_cache_add_active_or_unevictable(struct page *page,
|
|
unsigned long vma_flags)
|
|
{
|
|
VM_BUG_ON_PAGE(PageLRU(page), page);
|
|
|
|
if (likely((vma_flags & (VM_LOCKED | VM_SPECIAL)) != VM_LOCKED))
|
|
SetPageActive(page);
|
|
else if (!TestSetPageMlocked(page)) {
|
|
/*
|
|
* We use the irq-unsafe __mod_zone_page_stat because this
|
|
* counter is not modified from interrupt context, and the pte
|
|
* lock is held(spinlock), which implies preemption disabled.
|
|
*/
|
|
__mod_zone_page_state(page_zone(page), NR_MLOCK,
|
|
hpage_nr_pages(page));
|
|
count_vm_event(UNEVICTABLE_PGMLOCKED);
|
|
}
|
|
lru_cache_add(page);
|
|
}
|
|
|
|
/*
|
|
* If the page can not be invalidated, it is moved to the
|
|
* inactive list to speed up its reclaim. It is moved to the
|
|
* head of the list, rather than the tail, to give the flusher
|
|
* threads some time to write it out, as this is much more
|
|
* effective than the single-page writeout from reclaim.
|
|
*
|
|
* If the page isn't page_mapped and dirty/writeback, the page
|
|
* could reclaim asap using PG_reclaim.
|
|
*
|
|
* 1. active, mapped page -> none
|
|
* 2. active, dirty/writeback page -> inactive, head, PG_reclaim
|
|
* 3. inactive, mapped page -> none
|
|
* 4. inactive, dirty/writeback page -> inactive, head, PG_reclaim
|
|
* 5. inactive, clean -> inactive, tail
|
|
* 6. Others -> none
|
|
*
|
|
* In 4, why it moves inactive's head, the VM expects the page would
|
|
* be write it out by flusher threads as this is much more effective
|
|
* than the single-page writeout from reclaim.
|
|
*/
|
|
static void lru_deactivate_file_fn(struct page *page, struct lruvec *lruvec,
|
|
void *arg)
|
|
{
|
|
int lru, file;
|
|
bool active;
|
|
|
|
if (!PageLRU(page))
|
|
return;
|
|
|
|
if (PageUnevictable(page))
|
|
return;
|
|
|
|
/* Some processes are using the page */
|
|
if (page_mapped(page))
|
|
return;
|
|
|
|
active = PageActive(page);
|
|
file = page_is_file_cache(page);
|
|
lru = page_lru_base_type(page);
|
|
|
|
del_page_from_lru_list(page, lruvec, lru + active);
|
|
ClearPageActive(page);
|
|
ClearPageReferenced(page);
|
|
add_page_to_lru_list(page, lruvec, lru);
|
|
|
|
if (PageWriteback(page) || PageDirty(page)) {
|
|
/*
|
|
* PG_reclaim could be raced with end_page_writeback
|
|
* It can make readahead confusing. But race window
|
|
* is _really_ small and it's non-critical problem.
|
|
*/
|
|
SetPageReclaim(page);
|
|
} else {
|
|
/*
|
|
* The page's writeback ends up during pagevec
|
|
* We moves tha page into tail of inactive.
|
|
*/
|
|
list_move_tail(&page->lru, &lruvec->lists[lru]);
|
|
__count_vm_event(PGROTATED);
|
|
}
|
|
|
|
if (active)
|
|
__count_vm_event(PGDEACTIVATE);
|
|
update_page_reclaim_stat(lruvec, file, 0);
|
|
}
|
|
|
|
|
|
static void lru_lazyfree_fn(struct page *page, struct lruvec *lruvec,
|
|
void *arg)
|
|
{
|
|
if (PageLRU(page) && PageAnon(page) && PageSwapBacked(page) &&
|
|
!PageSwapCache(page) && !PageUnevictable(page)) {
|
|
bool active = PageActive(page);
|
|
|
|
del_page_from_lru_list(page, lruvec,
|
|
LRU_INACTIVE_ANON + active);
|
|
ClearPageActive(page);
|
|
ClearPageReferenced(page);
|
|
/*
|
|
* lazyfree pages are clean anonymous pages. They have
|
|
* SwapBacked flag cleared to distinguish normal anonymous
|
|
* pages
|
|
*/
|
|
ClearPageSwapBacked(page);
|
|
add_page_to_lru_list(page, lruvec, LRU_INACTIVE_FILE);
|
|
|
|
__count_vm_events(PGLAZYFREE, hpage_nr_pages(page));
|
|
count_memcg_page_event(page, PGLAZYFREE);
|
|
update_page_reclaim_stat(lruvec, 1, 0);
|
|
}
|
|
}
|
|
|
|
/*
|
|
* Drain pages out of the cpu's pagevecs.
|
|
* Either "cpu" is the current CPU, and preemption has already been
|
|
* disabled; or "cpu" is being hot-unplugged, and is already dead.
|
|
*/
|
|
void lru_add_drain_cpu(int cpu)
|
|
{
|
|
struct pagevec *pvec = &per_cpu(lru_add_pvec, cpu);
|
|
|
|
if (pagevec_count(pvec))
|
|
__pagevec_lru_add(pvec);
|
|
|
|
pvec = &per_cpu(lru_rotate_pvecs, cpu);
|
|
if (pagevec_count(pvec)) {
|
|
unsigned long flags;
|
|
|
|
/* No harm done if a racing interrupt already did this */
|
|
local_irq_save(flags);
|
|
pagevec_move_tail(pvec);
|
|
local_irq_restore(flags);
|
|
}
|
|
|
|
pvec = &per_cpu(lru_deactivate_file_pvecs, cpu);
|
|
if (pagevec_count(pvec))
|
|
pagevec_lru_move_fn(pvec, lru_deactivate_file_fn, NULL);
|
|
|
|
pvec = &per_cpu(lru_lazyfree_pvecs, cpu);
|
|
if (pagevec_count(pvec))
|
|
pagevec_lru_move_fn(pvec, lru_lazyfree_fn, NULL);
|
|
|
|
activate_page_drain(cpu);
|
|
}
|
|
|
|
/**
|
|
* deactivate_file_page - forcefully deactivate a file page
|
|
* @page: page to deactivate
|
|
*
|
|
* This function hints the VM that @page is a good reclaim candidate,
|
|
* for example if its invalidation fails due to the page being dirty
|
|
* or under writeback.
|
|
*/
|
|
void deactivate_file_page(struct page *page)
|
|
{
|
|
/*
|
|
* In a workload with many unevictable page such as mprotect,
|
|
* unevictable page deactivation for accelerating reclaim is pointless.
|
|
*/
|
|
if (PageUnevictable(page))
|
|
return;
|
|
|
|
if (likely(get_page_unless_zero(page))) {
|
|
struct pagevec *pvec = &get_cpu_var(lru_deactivate_file_pvecs);
|
|
|
|
if (!pagevec_add(pvec, page) || PageCompound(page))
|
|
pagevec_lru_move_fn(pvec, lru_deactivate_file_fn, NULL);
|
|
put_cpu_var(lru_deactivate_file_pvecs);
|
|
}
|
|
}
|
|
|
|
/**
|
|
* mark_page_lazyfree - make an anon page lazyfree
|
|
* @page: page to deactivate
|
|
*
|
|
* mark_page_lazyfree() moves @page to the inactive file list.
|
|
* This is done to accelerate the reclaim of @page.
|
|
*/
|
|
void mark_page_lazyfree(struct page *page)
|
|
{
|
|
if (PageLRU(page) && PageAnon(page) && PageSwapBacked(page) &&
|
|
!PageSwapCache(page) && !PageUnevictable(page)) {
|
|
struct pagevec *pvec = &get_cpu_var(lru_lazyfree_pvecs);
|
|
|
|
get_page(page);
|
|
if (!pagevec_add(pvec, page) || PageCompound(page))
|
|
pagevec_lru_move_fn(pvec, lru_lazyfree_fn, NULL);
|
|
put_cpu_var(lru_lazyfree_pvecs);
|
|
}
|
|
}
|
|
|
|
void lru_add_drain(void)
|
|
{
|
|
lru_add_drain_cpu(get_cpu());
|
|
put_cpu();
|
|
}
|
|
|
|
#ifdef CONFIG_SMP
|
|
|
|
static DEFINE_PER_CPU(struct work_struct, lru_add_drain_work);
|
|
|
|
static void lru_add_drain_per_cpu(struct work_struct *dummy)
|
|
{
|
|
lru_add_drain();
|
|
}
|
|
|
|
/*
|
|
* Doesn't need any cpu hotplug locking because we do rely on per-cpu
|
|
* kworkers being shut down before our page_alloc_cpu_dead callback is
|
|
* executed on the offlined cpu.
|
|
* Calling this function with cpu hotplug locks held can actually lead
|
|
* to obscure indirect dependencies via WQ context.
|
|
*/
|
|
void lru_add_drain_all(void)
|
|
{
|
|
static DEFINE_MUTEX(lock);
|
|
static struct cpumask has_work;
|
|
int cpu;
|
|
|
|
/*
|
|
* Make sure nobody triggers this path before mm_percpu_wq is fully
|
|
* initialized.
|
|
*/
|
|
if (WARN_ON(!mm_percpu_wq))
|
|
return;
|
|
|
|
mutex_lock(&lock);
|
|
cpumask_clear(&has_work);
|
|
|
|
for_each_online_cpu(cpu) {
|
|
struct work_struct *work = &per_cpu(lru_add_drain_work, cpu);
|
|
|
|
if (pagevec_count(&per_cpu(lru_add_pvec, cpu)) ||
|
|
pagevec_count(&per_cpu(lru_rotate_pvecs, cpu)) ||
|
|
pagevec_count(&per_cpu(lru_deactivate_file_pvecs, cpu)) ||
|
|
pagevec_count(&per_cpu(lru_lazyfree_pvecs, cpu)) ||
|
|
need_activate_page_drain(cpu)) {
|
|
INIT_WORK(work, lru_add_drain_per_cpu);
|
|
queue_work_on(cpu, mm_percpu_wq, work);
|
|
cpumask_set_cpu(cpu, &has_work);
|
|
}
|
|
}
|
|
|
|
for_each_cpu(cpu, &has_work)
|
|
flush_work(&per_cpu(lru_add_drain_work, cpu));
|
|
|
|
mutex_unlock(&lock);
|
|
}
|
|
#else
|
|
void lru_add_drain_all(void)
|
|
{
|
|
lru_add_drain();
|
|
}
|
|
#endif
|
|
|
|
/**
|
|
* release_pages - batched put_page()
|
|
* @pages: array of pages to release
|
|
* @nr: number of pages
|
|
*
|
|
* Decrement the reference count on all the pages in @pages. If it
|
|
* fell to zero, remove the page from the LRU and free it.
|
|
*/
|
|
void release_pages(struct page **pages, int nr)
|
|
{
|
|
int i;
|
|
LIST_HEAD(pages_to_free);
|
|
struct pglist_data *locked_pgdat = NULL;
|
|
struct lruvec *lruvec;
|
|
unsigned long flags;
|
|
unsigned int lock_batch;
|
|
|
|
for (i = 0; i < nr; i++) {
|
|
struct page *page = pages[i];
|
|
|
|
/*
|
|
* Make sure the IRQ-safe lock-holding time does not get
|
|
* excessive with a continuous string of pages from the
|
|
* same pgdat. The lock is held only if pgdat != NULL.
|
|
*/
|
|
if (locked_pgdat && ++lock_batch == SWAP_CLUSTER_MAX) {
|
|
spin_unlock_irqrestore(&locked_pgdat->lru_lock, flags);
|
|
locked_pgdat = NULL;
|
|
}
|
|
|
|
if (is_huge_zero_page(page))
|
|
continue;
|
|
|
|
if (is_zone_device_page(page)) {
|
|
if (locked_pgdat) {
|
|
spin_unlock_irqrestore(&locked_pgdat->lru_lock,
|
|
flags);
|
|
locked_pgdat = NULL;
|
|
}
|
|
/*
|
|
* ZONE_DEVICE pages that return 'false' from
|
|
* put_devmap_managed_page() do not require special
|
|
* processing, and instead, expect a call to
|
|
* put_page_testzero().
|
|
*/
|
|
if (put_devmap_managed_page(page))
|
|
continue;
|
|
}
|
|
|
|
page = compound_head(page);
|
|
if (!put_page_testzero(page))
|
|
continue;
|
|
|
|
if (PageCompound(page)) {
|
|
if (locked_pgdat) {
|
|
spin_unlock_irqrestore(&locked_pgdat->lru_lock, flags);
|
|
locked_pgdat = NULL;
|
|
}
|
|
__put_compound_page(page);
|
|
continue;
|
|
}
|
|
|
|
if (PageLRU(page)) {
|
|
struct pglist_data *pgdat = page_pgdat(page);
|
|
|
|
if (pgdat != locked_pgdat) {
|
|
if (locked_pgdat)
|
|
spin_unlock_irqrestore(&locked_pgdat->lru_lock,
|
|
flags);
|
|
lock_batch = 0;
|
|
locked_pgdat = pgdat;
|
|
spin_lock_irqsave(&locked_pgdat->lru_lock, flags);
|
|
}
|
|
|
|
lruvec = mem_cgroup_page_lruvec(page, locked_pgdat);
|
|
VM_BUG_ON_PAGE(!PageLRU(page), page);
|
|
__ClearPageLRU(page);
|
|
del_page_from_lru_list(page, lruvec, page_off_lru(page));
|
|
}
|
|
|
|
/* Clear Active bit in case of parallel mark_page_accessed */
|
|
__ClearPageActive(page);
|
|
__ClearPageWaiters(page);
|
|
|
|
list_add(&page->lru, &pages_to_free);
|
|
}
|
|
if (locked_pgdat)
|
|
spin_unlock_irqrestore(&locked_pgdat->lru_lock, flags);
|
|
|
|
mem_cgroup_uncharge_list(&pages_to_free);
|
|
free_unref_page_list(&pages_to_free);
|
|
}
|
|
EXPORT_SYMBOL(release_pages);
|
|
|
|
/*
|
|
* The pages which we're about to release may be in the deferred lru-addition
|
|
* queues. That would prevent them from really being freed right now. That's
|
|
* OK from a correctness point of view but is inefficient - those pages may be
|
|
* cache-warm and we want to give them back to the page allocator ASAP.
|
|
*
|
|
* So __pagevec_release() will drain those queues here. __pagevec_lru_add()
|
|
* and __pagevec_lru_add_active() call release_pages() directly to avoid
|
|
* mutual recursion.
|
|
*/
|
|
void __pagevec_release(struct pagevec *pvec)
|
|
{
|
|
if (!pvec->percpu_pvec_drained) {
|
|
lru_add_drain();
|
|
pvec->percpu_pvec_drained = true;
|
|
}
|
|
release_pages(pvec->pages, pagevec_count(pvec));
|
|
pagevec_reinit(pvec);
|
|
}
|
|
EXPORT_SYMBOL(__pagevec_release);
|
|
|
|
#ifdef CONFIG_TRANSPARENT_HUGEPAGE
|
|
/* used by __split_huge_page_refcount() */
|
|
void lru_add_page_tail(struct page *page, struct page *page_tail,
|
|
struct lruvec *lruvec, struct list_head *list)
|
|
{
|
|
const int file = 0;
|
|
|
|
VM_BUG_ON_PAGE(!PageHead(page), page);
|
|
VM_BUG_ON_PAGE(PageCompound(page_tail), page);
|
|
VM_BUG_ON_PAGE(PageLRU(page_tail), page);
|
|
VM_BUG_ON(NR_CPUS != 1 &&
|
|
!spin_is_locked(&lruvec_pgdat(lruvec)->lru_lock));
|
|
|
|
if (!list)
|
|
SetPageLRU(page_tail);
|
|
|
|
if (likely(PageLRU(page)))
|
|
list_add_tail(&page_tail->lru, &page->lru);
|
|
else if (list) {
|
|
/* page reclaim is reclaiming a huge page */
|
|
get_page(page_tail);
|
|
list_add_tail(&page_tail->lru, list);
|
|
} else {
|
|
struct list_head *list_head;
|
|
/*
|
|
* Head page has not yet been counted, as an hpage,
|
|
* so we must account for each subpage individually.
|
|
*
|
|
* Use the standard add function to put page_tail on the list,
|
|
* but then correct its position so they all end up in order.
|
|
*/
|
|
add_page_to_lru_list(page_tail, lruvec, page_lru(page_tail));
|
|
list_head = page_tail->lru.prev;
|
|
list_move_tail(&page_tail->lru, list_head);
|
|
}
|
|
|
|
if (!PageUnevictable(page))
|
|
update_page_reclaim_stat(lruvec, file, PageActive(page_tail));
|
|
}
|
|
#endif /* CONFIG_TRANSPARENT_HUGEPAGE */
|
|
|
|
static void __pagevec_lru_add_fn(struct page *page, struct lruvec *lruvec,
|
|
void *arg)
|
|
{
|
|
enum lru_list lru;
|
|
int was_unevictable = TestClearPageUnevictable(page);
|
|
|
|
VM_BUG_ON_PAGE(PageLRU(page), page);
|
|
|
|
SetPageLRU(page);
|
|
/*
|
|
* Page becomes evictable in two ways:
|
|
* 1) Within LRU lock [munlock_vma_pages() and __munlock_pagevec()].
|
|
* 2) Before acquiring LRU lock to put the page to correct LRU and then
|
|
* a) do PageLRU check with lock [check_move_unevictable_pages]
|
|
* b) do PageLRU check before lock [clear_page_mlock]
|
|
*
|
|
* (1) & (2a) are ok as LRU lock will serialize them. For (2b), we need
|
|
* following strict ordering:
|
|
*
|
|
* #0: __pagevec_lru_add_fn #1: clear_page_mlock
|
|
*
|
|
* SetPageLRU() TestClearPageMlocked()
|
|
* smp_mb() // explicit ordering // above provides strict
|
|
* // ordering
|
|
* PageMlocked() PageLRU()
|
|
*
|
|
*
|
|
* if '#1' does not observe setting of PG_lru by '#0' and fails
|
|
* isolation, the explicit barrier will make sure that page_evictable
|
|
* check will put the page in correct LRU. Without smp_mb(), SetPageLRU
|
|
* can be reordered after PageMlocked check and can make '#1' to fail
|
|
* the isolation of the page whose Mlocked bit is cleared (#0 is also
|
|
* looking at the same page) and the evictable page will be stranded
|
|
* in an unevictable LRU.
|
|
*/
|
|
smp_mb();
|
|
|
|
if (page_evictable(page)) {
|
|
lru = page_lru(page);
|
|
update_page_reclaim_stat(lruvec, page_is_file_cache(page),
|
|
PageActive(page));
|
|
if (was_unevictable)
|
|
count_vm_event(UNEVICTABLE_PGRESCUED);
|
|
} else {
|
|
lru = LRU_UNEVICTABLE;
|
|
ClearPageActive(page);
|
|
SetPageUnevictable(page);
|
|
if (!was_unevictable)
|
|
count_vm_event(UNEVICTABLE_PGCULLED);
|
|
}
|
|
|
|
add_page_to_lru_list(page, lruvec, lru);
|
|
trace_mm_lru_insertion(page, lru);
|
|
}
|
|
|
|
/*
|
|
* Add the passed pages to the LRU, then drop the caller's refcount
|
|
* on them. Reinitialises the caller's pagevec.
|
|
*/
|
|
void __pagevec_lru_add(struct pagevec *pvec)
|
|
{
|
|
pagevec_lru_move_fn(pvec, __pagevec_lru_add_fn, NULL);
|
|
}
|
|
EXPORT_SYMBOL(__pagevec_lru_add);
|
|
|
|
/**
|
|
* pagevec_lookup_entries - gang pagecache lookup
|
|
* @pvec: Where the resulting entries are placed
|
|
* @mapping: The address_space to search
|
|
* @start: The starting entry index
|
|
* @nr_entries: The maximum number of pages
|
|
* @indices: The cache indices corresponding to the entries in @pvec
|
|
*
|
|
* pagevec_lookup_entries() will search for and return a group of up
|
|
* to @nr_pages pages and shadow entries in the mapping. All
|
|
* entries are placed in @pvec. pagevec_lookup_entries() takes a
|
|
* reference against actual pages in @pvec.
|
|
*
|
|
* The search returns a group of mapping-contiguous entries with
|
|
* ascending indexes. There may be holes in the indices due to
|
|
* not-present entries.
|
|
*
|
|
* pagevec_lookup_entries() returns the number of entries which were
|
|
* found.
|
|
*/
|
|
unsigned pagevec_lookup_entries(struct pagevec *pvec,
|
|
struct address_space *mapping,
|
|
pgoff_t start, unsigned nr_entries,
|
|
pgoff_t *indices)
|
|
{
|
|
pvec->nr = find_get_entries(mapping, start, nr_entries,
|
|
pvec->pages, indices);
|
|
return pagevec_count(pvec);
|
|
}
|
|
|
|
/**
|
|
* pagevec_remove_exceptionals - pagevec exceptionals pruning
|
|
* @pvec: The pagevec to prune
|
|
*
|
|
* pagevec_lookup_entries() fills both pages and exceptional radix
|
|
* tree entries into the pagevec. This function prunes all
|
|
* exceptionals from @pvec without leaving holes, so that it can be
|
|
* passed on to page-only pagevec operations.
|
|
*/
|
|
void pagevec_remove_exceptionals(struct pagevec *pvec)
|
|
{
|
|
int i, j;
|
|
|
|
for (i = 0, j = 0; i < pagevec_count(pvec); i++) {
|
|
struct page *page = pvec->pages[i];
|
|
if (!radix_tree_exceptional_entry(page))
|
|
pvec->pages[j++] = page;
|
|
}
|
|
pvec->nr = j;
|
|
}
|
|
|
|
/**
|
|
* pagevec_lookup_range - gang pagecache lookup
|
|
* @pvec: Where the resulting pages are placed
|
|
* @mapping: The address_space to search
|
|
* @start: The starting page index
|
|
* @end: The final page index
|
|
*
|
|
* pagevec_lookup_range() will search for & return a group of up to PAGEVEC_SIZE
|
|
* pages in the mapping starting from index @start and upto index @end
|
|
* (inclusive). The pages are placed in @pvec. pagevec_lookup() takes a
|
|
* reference against the pages in @pvec.
|
|
*
|
|
* The search returns a group of mapping-contiguous pages with ascending
|
|
* indexes. There may be holes in the indices due to not-present pages. We
|
|
* also update @start to index the next page for the traversal.
|
|
*
|
|
* pagevec_lookup_range() returns the number of pages which were found. If this
|
|
* number is smaller than PAGEVEC_SIZE, the end of specified range has been
|
|
* reached.
|
|
*/
|
|
unsigned pagevec_lookup_range(struct pagevec *pvec,
|
|
struct address_space *mapping, pgoff_t *start, pgoff_t end)
|
|
{
|
|
pvec->nr = find_get_pages_range(mapping, start, end, PAGEVEC_SIZE,
|
|
pvec->pages);
|
|
return pagevec_count(pvec);
|
|
}
|
|
EXPORT_SYMBOL(pagevec_lookup_range);
|
|
|
|
unsigned pagevec_lookup_range_tag(struct pagevec *pvec,
|
|
struct address_space *mapping, pgoff_t *index, pgoff_t end,
|
|
int tag)
|
|
{
|
|
pvec->nr = find_get_pages_range_tag(mapping, index, end, tag,
|
|
PAGEVEC_SIZE, pvec->pages);
|
|
return pagevec_count(pvec);
|
|
}
|
|
EXPORT_SYMBOL(pagevec_lookup_range_tag);
|
|
|
|
unsigned pagevec_lookup_range_nr_tag(struct pagevec *pvec,
|
|
struct address_space *mapping, pgoff_t *index, pgoff_t end,
|
|
int tag, unsigned max_pages)
|
|
{
|
|
pvec->nr = find_get_pages_range_tag(mapping, index, end, tag,
|
|
min_t(unsigned int, max_pages, PAGEVEC_SIZE), pvec->pages);
|
|
return pagevec_count(pvec);
|
|
}
|
|
EXPORT_SYMBOL(pagevec_lookup_range_nr_tag);
|
|
/*
|
|
* Perform any setup for the swap system
|
|
*/
|
|
void __init swap_setup(void)
|
|
{
|
|
unsigned long megs = totalram_pages >> (20 - PAGE_SHIFT);
|
|
|
|
/* Use a smaller cluster for small-memory machines */
|
|
if (megs < 16)
|
|
page_cluster = 2;
|
|
else
|
|
page_cluster = 3;
|
|
/*
|
|
* Right now other parts of the system means that we
|
|
* _really_ don't want to cluster much more
|
|
*/
|
|
}
|