TechPanelGM/kernel_xiaomi_sm8250
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

scripts/kallsyms: fix definitely-lost memory leak

Browse Source 
[ Upstream commit 21915eca088dc271c970e8351290e83d938114ac ]

build_initial_tok_table() overwrites unused sym_entry to shrink the
table size. Before the entry is overwritten, table[i].sym must be freed
since it is malloc'ed data.

This fixes the 'definitely lost' report from valgrind. I ran valgrind
against x86_64_defconfig of v5.4-rc8 kernel, and here is the summary:

[Before the fix]

  LEAK SUMMARY:
     definitely lost: 53,184 bytes in 2,874 blocks

[After the fix]

  LEAK SUMMARY:
     definitely lost: 0 bytes in 0 blocks

Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
This commit is contained in:
Masahiro Yamada
2019-11-24 01:04:30 +09:00
committed by Greg Kroah-Hartman
parent 79a1eae9e4
commit e9bcb92472
1 changed files with 2 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
scripts/kallsyms.c
View File

@@ -491,6 +491,8 @@ static void build_initial_tok_table(void)
table[pos] = table[i]; table[pos] = table[i];
learn_symbol(table[pos].sym, table[pos].len); learn_symbol(table[pos].sym, table[pos].len);
pos++; pos++;
} else {
free(table[i].sym);
} }
} }
table_cnt = pos; table_cnt = pos;