TechPanelGM/kernel_xiaomi_sm8250
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

f2fs: fix a redundant call to f2fs_balance_fs if an error occurs

Browse Source 
[ Upstream commit 28e18ee636ba28532dbe425540af06245a0bbecb ]

The  uninitialized variable dn.node_changed does not get set when a
call to f2fs_get_node_page fails.  This uninitialized value gets used
in the call to f2fs_balance_fs() that may or not may not balances
dirty node and dentry pages depending on the uninitialized state of
the variable. Fix this by only calling f2fs_balance_fs if err is
not set.

Thanks to Jaegeuk Kim for suggesting an appropriate fix.

Addresses-Coverity: ("Uninitialized scalar variable")
Fixes: 2a34076070 ("f2fs: call f2fs_balance_fs only when node was changed")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Reviewed-by: Chao Yu <yuchao0@huawei.com>
Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
This commit is contained in:
Colin Ian King
2021-03-04 09:21:18 +00:00
committed by Greg Kroah-Hartman
parent 312a7bac61
commit b8ee94065e
1 changed files with 2 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
fs/f2fs/inline.c
View File

@@ -220,7 +220,8 @@ int f2fs_convert_inline_inode(struct inode *inode)
f2fs_put_page(page, 1); f2fs_put_page(page, 1);
f2fs_balance_fs(sbi, dn.node_changed); if (!err)
f2fs_balance_fs(sbi, dn.node_changed);
return err; return err;
} }