TechPanelGM/kernel_xiaomi_sm8250
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

net: remove unneeded break

Browse Source 
[ Upstream commit 7ebb9db011088f9bd357791f49cb7012e66f29e2 ]

A break is not needed if it is preceded by a return or goto

Signed-off-by: Tom Rix <trix@redhat.com>
Link: https://lore.kernel.org/r/20201019172607.31622-1-trix@redhat.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Stable-dep-of: bbc404d20d1b ("ixgbe: Fix an error handling path in ixgbe_read_iosf_sb_reg_x550()")
Signed-off-by: Sasha Levin <sashal@kernel.org>
This commit is contained in:
Tom Rix
2020-10-19 10:26:07 -07:00
committed by Greg Kroah-Hartman
parent 86ca4cb47d
commit b2460d9640
4 changed files with 0 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
drivers/net/ethernet/aquantia/atlantic/aq_nic.c
View File

@@ -823,7 +823,6 @@ int aq_nic_set_link_ksettings(struct aq_nic_s *self,
default: default:
err = -1; err = -1;
goto err_exit; goto err_exit;
break;
} }
if (!(self->aq_nic_cfg.aq_hw_caps->link_speed_msk & rate)) { if (!(self->aq_nic_cfg.aq_hw_caps->link_speed_msk & rate)) {
err = -1; err = -1;

1
drivers/net/ethernet/cisco/enic/enic_ethtool.c
View File

@@ -454,7 +454,6 @@ static int enic_grxclsrule(struct enic *enic, struct ethtool_rxnfc *cmd)
break; break;
default: default:
return -EINVAL; return -EINVAL;
break;
} }
fsp->h_u.tcp_ip4_spec.ip4src = flow_get_u32_src(&n->keys); fsp->h_u.tcp_ip4_spec.ip4src = flow_get_u32_src(&n->keys);

1
drivers/net/ethernet/intel/ixgbe/ixgbe_x540.c
View File

@@ -350,7 +350,6 @@ static s32 ixgbe_calc_eeprom_checksum_X540(struct ixgbe_hw *hw)
if (ixgbe_read_eerd_generic(hw, pointer, &length)) { if (ixgbe_read_eerd_generic(hw, pointer, &length)) {
hw_dbg(hw, "EEPROM read failed\n"); hw_dbg(hw, "EEPROM read failed\n");
return IXGBE_ERR_EEPROM; return IXGBE_ERR_EEPROM;
break;
} }
/* Skip pointer section if length is invalid. */ /* Skip pointer section if length is invalid. */

4
drivers/net/wan/lmc/lmc_proto.c
View File

@@ -103,17 +103,13 @@ __be16 lmc_proto_type(lmc_softc_t *sc, struct sk_buff *skb) /*FOLD00*/
switch(sc->if_type){ switch(sc->if_type){
case LMC_PPP: case LMC_PPP:
return hdlc_type_trans(skb, sc->lmc_device); return hdlc_type_trans(skb, sc->lmc_device);
break;
case LMC_NET: case LMC_NET:
return htons(ETH_P_802_2); return htons(ETH_P_802_2);
break;
case LMC_RAW: /* Packet type for skbuff kind of useless */ case LMC_RAW: /* Packet type for skbuff kind of useless */
return htons(ETH_P_802_2); return htons(ETH_P_802_2);
break;
default: default:
printk(KERN_WARNING "%s: No protocol set for this interface, assuming 802.2 (which is wrong!!)\n", sc->name); printk(KERN_WARNING "%s: No protocol set for this interface, assuming 802.2 (which is wrong!!)\n", sc->name);
return htons(ETH_P_802_2); return htons(ETH_P_802_2);
break;
} }
lmc_trace(sc->lmc_device, "lmc_proto_tye out"); lmc_trace(sc->lmc_device, "lmc_proto_tye out");