TechPanelGM/kernel_xiaomi_sm8250
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

lan78xx: Fix memory leaks

Browse Source 
[ Upstream commit b9cbf8a64865b50fd0f4a3915fa00ac7365cdf8f ]

In lan78xx_probe(), a new urb is allocated through usb_alloc_urb() and
saved to 'dev->urb_intr'. However, in the following execution, if an error
occurs, 'dev->urb_intr' is not deallocated, leading to memory leaks. To fix
this issue, invoke usb_free_urb() to free the allocated urb before
returning from the function.

Signed-off-by: Wenwen Wang <wenwen@cs.uga.edu>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>
This commit is contained in:
Wenwen Wang
2019-08-14 11:23:13 -05:00
committed by Greg Kroah-Hartman
parent 375ab446ec
commit 9ea1feadf5
1 changed files with 5 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
drivers/net/usb/lan78xx.c
View File

@@ -3799,7 +3799,7 @@ static int lan78xx_probe(struct usb_interface *intf,
ret = register_netdev(netdev); ret = register_netdev(netdev);
if (ret != 0) { if (ret != 0) {
netif_err(dev, probe, netdev, "couldn't register the device\n"); netif_err(dev, probe, netdev, "couldn't register the device\n");
goto out3; goto out4;
} }
usb_set_intfdata(intf, dev); usb_set_intfdata(intf, dev);
@@ -3814,12 +3814,14 @@ static int lan78xx_probe(struct usb_interface *intf,
ret = lan78xx_phy_init(dev); ret = lan78xx_phy_init(dev);
if (ret < 0) if (ret < 0)
goto out4; goto out5;
return 0; return 0;
out4: out5:
unregister_netdev(netdev); unregister_netdev(netdev);
out4:
usb_free_urb(dev->urb_intr);
out3: out3:
lan78xx_unbind(dev, intf); lan78xx_unbind(dev, intf);
out2: out2: