TechPanelGM/kernel_xiaomi_sm8250
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

mfd: ab8500-sysctrl: Fix Constify, printk => pr_info and formatting issues

Browse Source 
WARNING: char * array declaration might be better as static const
+       static char *pss[] = {"ab8500_ac", "pm2301", "ab8500_usb"};

WARNING: Prefer [subsystem eg: netdev]_info([subsystem]dev, ... then dev_info(dev, ... then
 pr_info(...  to printk(KERN_INFO ...
+                       printk(KERN_INFO

WARNING: quoted string split across lines
+                              "Charger \"%s\" is connected with known battery."
+                              " Rebooting.\n",

WARNING: quoted string split across lines
+                                       "unable to set sysClkReq%dRfClkBuf: "
+                                       "%d\n", j + 1, ret);

total: 0 errors, 4 warnings, 199 lines checked

Cc: Linus Walleij <linus.walleij@linaro.org>
Signed-off-by: Lee Jones <lee.jones@linaro.org>
This commit is contained in:
Lee Jones
2015-10-28 11:11:05 +00:00
parent df36442cfe
commit 63b4fd7502
1 changed files with 6 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
drivers/mfd/ab8500-sysctrl.c
View File

@@ -27,7 +27,7 @@ static void ab8500_power_off(void)
{ {
sigset_t old; sigset_t old;
sigset_t all; sigset_t all;
static char *pss[] = {"ab8500_ac", "pm2301", "ab8500_usb"}; static const char * const pss[] = {"ab8500_ac", "pm2301", "ab8500_usb"};
int i; int i;
bool charger_present = false; bool charger_present = false;
union power_supply_propval val; union power_supply_propval val;
@@ -68,10 +68,9 @@ static void ab8500_power_off(void)
ret = power_supply_get_property(psy, ret = power_supply_get_property(psy,
POWER_SUPPLY_PROP_TECHNOLOGY, &val); POWER_SUPPLY_PROP_TECHNOLOGY, &val);
if (!ret && val.intval != POWER_SUPPLY_TECHNOLOGY_UNKNOWN) { if (!ret && val.intval != POWER_SUPPLY_TECHNOLOGY_UNKNOWN) {
printk(KERN_INFO pr_info("Charger '%s' is connected with known battery",
"Charger \"%s\" is connected with known battery."
" Rebooting.\n",
pss[i]); pss[i]);
pr_info(" - Rebooting.\n");
machine_restart("charging"); machine_restart("charging");
} }
power_supply_put(psy); power_supply_put(psy);
@@ -161,8 +160,8 @@ static int ab8500_sysctrl_probe(struct platform_device *pdev)
pdata->initial_req_buf_config[j]); pdata->initial_req_buf_config[j]);
if (ret < 0) { if (ret < 0) {
dev_err(&pdev->dev, dev_err(&pdev->dev,
"unable to set sysClkReq%dRfClkBuf: " "Can't set sysClkReq%dRfClkBuf: %d\n",
"%d\n", j + 1, ret); j + 1, ret);
} }
} }
} }