TechPanelGM/kernel_xiaomi_sm8250
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

misc: rtsx: Fix an error handling path in rtsx_pci_probe()

Browse Source 
[ Upstream commit 44fd1917314e9d4f53dd95dd65df1c152f503d3a ]

If an error occurs after a successful idr_alloc() call, the corresponding
resource must be released with idr_remove() as already done in the .remove
function.

Update the error handling path to add the missing idr_remove() call.

Fixes: ada8a8a13b ("mfd: Add realtek pcie card reader driver")
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Link: https://lore.kernel.org/r/e8dc41716cbf52fb37a12e70d8972848e69df6d6.1655271216.git.christophe.jaillet@wanadoo.fr
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
This commit is contained in:
Christophe JAILLET
2022-06-15 07:33:44 +02:00
committed by Greg Kroah-Hartman
parent 4db00c2fa6
commit 5a52c24a2b
1 changed files with 5 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
drivers/misc/cardreader/rtsx_pcr.c
View File

@@ -1479,7 +1479,7 @@ static int rtsx_pci_probe(struct pci_dev *pcidev,
pcr->remap_addr = ioremap_nocache(base, len); pcr->remap_addr = ioremap_nocache(base, len);
if (!pcr->remap_addr) { if (!pcr->remap_addr) {
ret = -ENOMEM; ret = -ENOMEM;
goto free_handle; goto free_idr;
} }
pcr->rtsx_resv_buf = dma_alloc_coherent(&(pcidev->dev), pcr->rtsx_resv_buf = dma_alloc_coherent(&(pcidev->dev),
@@ -1541,6 +1541,10 @@ static int rtsx_pci_probe(struct pci_dev *pcidev,
pcr->rtsx_resv_buf, pcr->rtsx_resv_buf_addr); pcr->rtsx_resv_buf, pcr->rtsx_resv_buf_addr);
unmap: unmap:
iounmap(pcr->remap_addr); iounmap(pcr->remap_addr);
free_idr:
spin_lock(&rtsx_pci_lock);
idr_remove(&rtsx_pci_idr, pcr->id);
spin_unlock(&rtsx_pci_lock);
free_handle: free_handle:
kfree(handle); kfree(handle);
free_pcr: free_pcr: