TechPanelGM/kernel_xiaomi_sm8250
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

hwmon: (max6621) Inverted if condition in max6621_read()

Browse Source 
We intended to test for failure here but accidentally tested for
success.  It means that we don't set "*val" to true and it means that
if i2c_smbus_write_byte() does fail then we return success.

Fixes: e7895864b0d7 ("hwmon: (max6621) Add support for Maxim MAX6621 temperature sensor")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Vadim Pasternak <vadimp@mellanox.com>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
This commit is contained in:
Dan Carpenter
2017-10-24 12:47:42 +03:00
committed by Guenter Roeck
parent a3bdc5b5bd
commit 5813da157f
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
drivers/hwmon/max6621.c
View File

@@ -296,7 +296,7 @@ max6621_read(struct device *dev, enum hwmon_sensor_types type, u32 attr,
if (regval) { if (regval) {
ret = i2c_smbus_write_byte(data->client, ret = i2c_smbus_write_byte(data->client,
MAX6621_CLEAR_ALERT_REG); MAX6621_CLEAR_ALERT_REG);
if (!ret) if (ret)
return ret; return ret;
} }