TechPanelGM/kernel_xiaomi_sm8250
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

hwmon: (w83773g) Fix fault detection and reporting

Browse Source 
Smatch reports:

drivers/hwmon/w83773g.c:105
	get_fault() warn: shift has higher precedence than mask

Code analysis shows that the code is indeed wrong.
Fix it, and while we are at it, drop unnecessary typecast.

Fixes: 86a10c802362 ("hwmon: Add W83773G driver")
Cc: Lei YU <mine260309@gmail.com>
Reviewed-by: Lei YU <mine260309@gmail.com>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
This commit is contained in:
Guenter Roeck
2017-12-03 15:27:56 -08:00
parent a7a9b15a35
commit 571e3f3a8e
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
drivers/hwmon/w83773g.c
View File

@@ -102,7 +102,7 @@ static int get_fault(struct regmap *regmap, int index, long *val)
if (ret < 0)
return ret;
*val = (u8)regval & 0x04 >> 2;
*val = (regval & 0x04) >> 2;
return 0;
}