TechPanelGM/kernel_xiaomi_sm8250
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

iio: light: si1133: fix uninitialized resp variable

Browse Source 
Read response register to detect any error.

Signed-off-by: Maxime Roussin-Bélanger <maxime.roussinbelanger@gmail.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
This commit is contained in:
Maxime Roussin-Bélanger
2018-07-31 16:13:21 -04:00
committed by Jonathan Cameron
parent 2b4ec22d36
commit 496fb59e12
1 changed files with 3 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
drivers/iio/light/si1133.c
View File

@@ -409,6 +409,9 @@ static int si1133_command(struct si1133_data *data, u8 cmd)
err = -ETIMEDOUT; err = -ETIMEDOUT;
goto out; goto out;
} }
err = regmap_read(data->regmap, SI1133_REG_RESPONSE0, &resp);
if (err)
goto out;
} else { } else {
err = regmap_read_poll_timeout(data->regmap, err = regmap_read_poll_timeout(data->regmap,
SI1133_REG_RESPONSE0, resp, SI1133_REG_RESPONSE0, resp,