TechPanelGM/kernel_xiaomi_sm8250
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

soc: qcom: Fix memcpy operations in ramdump_read

Browse Source 
Currently, for device memory addresses, which are not
aligned on 8 byte boundary, ramdump_read() copies the
bytes till the start of next aligned address. However,
this calculation does not take into account the case,
where copy_size is less that the number of bytes till
next alignment. This causes memcpy to copy device
memory to region, which is outside of the allocated
buffer. Fix this by copying only the copy_size buffer
for this case.

Change-Id: I918ab5886d664f89c0eebd99972f5b9960e1ae00
Signed-off-by: Neeraj Upadhyay <neeraju@codeaurora.org>
This commit is contained in:
Neeraj Upadhyay
2020-10-12 09:45:39 +05:30
parent cbf74decfa
commit 482d6eea6b
1 changed files with 2 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
drivers/soc/qcom/ramdump.c
View File

@@ -241,6 +241,8 @@ static ssize_t ramdump_read(struct file *filep, char __user *buf, size_t count,
if ((unsigned long)device_mem & 0x7) { if ((unsigned long)device_mem & 0x7) {
bytes_before = 8 - ((unsigned long)device_mem & 0x7); bytes_before = 8 - ((unsigned long)device_mem & 0x7);
bytes_before = min_t(unsigned long, (unsigned long)copy_size,
bytes_before);
memcpy_fromio(alignbuf, device_mem, bytes_before); memcpy_fromio(alignbuf, device_mem, bytes_before);
device_mem += bytes_before; device_mem += bytes_before;
alignbuf += bytes_before; alignbuf += bytes_before;