TechPanelGM/kernel_xiaomi_sm8250
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

recordmcount: Fix memory leaks in the uwrite function

Browse Source 
[ Upstream commit fa359d068574d29e7d2f0fdd0ebe4c6a12b5cfb9 ]

Common realloc mistake: 'file_append' nulled but not freed upon failure

Link: https://lkml.kernel.org/r/20230426010527.703093-1-zenghao@kylinos.cn

Signed-off-by: Hao Zeng <zenghao@kylinos.cn>
Suggested-by: Steven Rostedt <rostedt@goodmis.org>
Signed-off-by: Steven Rostedt (Google) <rostedt@goodmis.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
This commit is contained in:
Hao Zeng
2023-04-26 09:05:27 +08:00
committed by Greg Kroah-Hartman
parent 446e8d258a
commit 444ec00540
1 changed files with 5 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
scripts/recordmcount.c
View File

@@ -132,6 +132,7 @@ uwrite(int const fd, void const *const buf, size_t const count)
{ {
size_t cnt = count; size_t cnt = count;
off_t idx = 0; off_t idx = 0;
void *p = NULL;
file_updated = 1; file_updated = 1;
@@ -139,7 +140,10 @@ uwrite(int const fd, void const *const buf, size_t const count)
off_t aoffset = (file_ptr + count) - file_end; off_t aoffset = (file_ptr + count) - file_end;
if (aoffset > file_append_size) { if (aoffset > file_append_size) {
file_append = realloc(file_append, aoffset); p = realloc(file_append, aoffset);
if (!p)
free(file_append);
file_append = p;
file_append_size = aoffset; file_append_size = aoffset;
} }
if (!file_append) { if (!file_append) {