TechPanelGM/kernel_xiaomi_sm8250
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

msm: ADSPRPC: Restrict untrusted applications from attaching to GuestOS

Browse Source 
Untrusted application can attach to guestOS and staticPD if it can
somehow make INIT IOCTL call with ATTACH flag. This is a potential
security issue as the untrusted application can crash guestOS or
staticPD. Restrict attach to guestOS or staticPD request if request
is being made using non-secure device node.

Change-Id: I322c7b242fd0baaf1c1bce2d83b992fecb0ca593
Acked-by: Ekansh Gupta <ekangupt@qti.qualcomm.com>
Signed-off-by: Vamsi Krishna Gattupalli <quic_vgattupa@quicinc.com>
This commit is contained in:
Vamsi Krishna Gattupalli
2022-06-07 11:06:20 +05:30
parent 3e7bb833ef
commit 40cb5f52c2
1 changed files with 13 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
drivers/char/adsprpc.c
View File

@@ -2543,6 +2543,12 @@ static int fastrpc_init_process(struct fastrpc_file *fl,
remote_arg_t ra[1]; remote_arg_t ra[1];
int tgid = fl->tgid; int tgid = fl->tgid;
if (fl->dev_minor == MINOR_NUM_DEV) {
err = -ECONNREFUSED;
pr_err("adsprpc: %s: untrusted app trying to attach to privileged DSP PD\n",
__func__);
return err;
}
ra[0].buf.pv = (void *)&tgid; ra[0].buf.pv = (void *)&tgid;
ra[0].buf.len = sizeof(tgid); ra[0].buf.len = sizeof(tgid);
ioctl.inv.handle = FASTRPC_STATIC_HANDLE_PROCESS_GROUP; ioctl.inv.handle = FASTRPC_STATIC_HANDLE_PROCESS_GROUP;
@@ -2683,6 +2689,13 @@ static int fastrpc_init_process(struct fastrpc_file *fl,
unsigned int pageslen; unsigned int pageslen;
} inbuf; } inbuf;
if (fl->dev_minor == MINOR_NUM_DEV) {
err = -ECONNREFUSED;
pr_err("adsprpc: %s: untrusted app trying to attach to audio PD\n",
__func__);
return err;
}
if (!init->filelen) if (!init->filelen)
goto bail; goto bail;