TechPanelGM/kernel_xiaomi_sm8250
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

checkpatch: Fix the commit log false positive warnings

Browse Source 
Checkpatch is throwing a warning for lines that contains file delta
in the commit log.

WARNING: Possible unwrapped commit description
(prefer a maximum 75 chars per line)
kerneldir/msm-abc-xyz123.dtsi
              | 68 ++++++++++++++++++++++++++++++++++++++++----

This file delta line of the patch should be ignored for maximum characters
per line check and is taken care of already, but it's not covering if the
file has '-' in its name. Update the conditional check to cover this case.

Change-Id: If37691aa897f8a991c1643a08fbde45cc4afaaf7
Signed-off-by: Venkata Narendra Kumar Gutta <vnkgutta@codeaurora.org>
This commit is contained in:
Venkata Narendra Kumar Gutta
2019-05-06 15:44:44 -07:00
parent e59d225863
commit 39229466a6
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
scripts/checkpatch.pl
View File

@@ -2817,7 +2817,7 @@ sub process {
# Check for line lengths > 75 in commit log, warn once # Check for line lengths > 75 in commit log, warn once
if ($in_commit_log && !$commit_log_long_line && if ($in_commit_log && !$commit_log_long_line &&
length($line) > 75 && length($line) > 75 &&
!($line =~ /^\s*[a-zA-Z0-9_\/\.]+\s+\|\s+\d+/ || !($line =~ /^\s*[a-zA-Z0-9_\/\.\-]+\s+\|\s+\d+/ ||
# file delta changes # file delta changes
$line =~ /^\s*(?:[\w\.\-]+\/)++[\w\.\-]+:/ || $line =~ /^\s*(?:[\w\.\-]+\/)++[\w\.\-]+:/ ||
# filename then : # filename then :