TechPanelGM/kernel_xiaomi_sm8250
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

usb: gadget: fsl_qe_udc: validate endpoint index for ch9 udc

Browse Source 
[ Upstream commit ce9daa2efc0872a9a68ea51dc8000df05893ef2e ]

We should verify the bound of the array to assure that host
may not manipulate the index to point past endpoint array.

Signed-off-by: Ma Ke <make_ruc2021@163.com>
Acked-by: Li Yang <leoyang.li@nxp.com>
Link: https://lore.kernel.org/r/20230628081511.186850-1-make_ruc2021@163.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
This commit is contained in:
Ma Ke
2023-06-28 16:15:11 +08:00
committed by Greg Kroah-Hartman
parent 0600d5f18a
commit 2ce38bd3e9
1 changed files with 5 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
drivers/usb/gadget/udc/fsl_qe_udc.c
View File

@@ -1950,9 +1950,13 @@ static void ch9getstatus(struct qe_udc *udc, u8 request_type, u16 value,
} else if ((request_type & USB_RECIP_MASK) == USB_RECIP_ENDPOINT) { } else if ((request_type & USB_RECIP_MASK) == USB_RECIP_ENDPOINT) {
/* Get endpoint status */ /* Get endpoint status */
int pipe = index & USB_ENDPOINT_NUMBER_MASK; int pipe = index & USB_ENDPOINT_NUMBER_MASK;
struct qe_ep *target_ep = &udc->eps[pipe]; struct qe_ep *target_ep;
u16 usep; u16 usep;
if (pipe >= USB_MAX_ENDPOINTS)
goto stall;
target_ep = &udc->eps[pipe];
/* stall if endpoint doesn't exist */ /* stall if endpoint doesn't exist */
if (!target_ep->ep.desc) if (!target_ep->ep.desc)
goto stall; goto stall;