TechPanelGM/kernel_xiaomi_sm8250
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

net/iucv: Avoid explicit cpumask var allocation on stack

Browse Source 
[ Upstream commit be4e1304419c99a164b4c0e101c7c2a756b635b9 ]

For CONFIG_CPUMASK_OFFSTACK=y kernel, explicit allocation of cpumask
variable on stack is not recommended since it can cause potential stack
overflow.

Instead, kernel code should always use *cpumask_var API(s) to allocate
cpumask var in config-neutral way, leaving allocation strategy to
CONFIG_CPUMASK_OFFSTACK.

Use *cpumask_var API(s) to address it.

Signed-off-by: Dawei Li <dawei.li@shingroup.cn>
Reviewed-by: Alexandra Winter <wintera@linux.ibm.com>
Link: https://lore.kernel.org/r/20240331053441.1276826-2-dawei.li@shingroup.cn
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
This commit is contained in:
Dawei Li
2024-03-31 13:34:40 +08:00
committed by Greg Kroah-Hartman
parent b71348be12
commit 2b085521be
1 changed files with 18 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

26
net/iucv/iucv.c
View File

@@ -578,7 +578,7 @@ static void iucv_setmask_mp(void)
*/ */
static void iucv_setmask_up(void) static void iucv_setmask_up(void)
{ {
cpumask_t cpumask; static cpumask_t cpumask;
int cpu; int cpu;
/* Disable all cpu but the first in cpu_irq_cpumask. */ /* Disable all cpu but the first in cpu_irq_cpumask. */
@@ -686,23 +686,33 @@ static int iucv_cpu_online(unsigned int cpu)
static int iucv_cpu_down_prep(unsigned int cpu) static int iucv_cpu_down_prep(unsigned int cpu)
{ {
cpumask_t cpumask; cpumask_var_t cpumask;
int ret = 0;
if (!iucv_path_table) if (!iucv_path_table)
return 0; return 0;
cpumask_copy(&cpumask, &iucv_buffer_cpumask); if (!alloc_cpumask_var(&cpumask, GFP_KERNEL))
cpumask_clear_cpu(cpu, &cpumask); return -ENOMEM;
if (cpumask_empty(&cpumask))
cpumask_copy(cpumask, &iucv_buffer_cpumask);
cpumask_clear_cpu(cpu, cpumask);
if (cpumask_empty(cpumask)) {
/* Can't offline last IUCV enabled cpu. */ /* Can't offline last IUCV enabled cpu. */
return -EINVAL; ret = -EINVAL;
goto __free_cpumask;
}
iucv_retrieve_cpu(NULL); iucv_retrieve_cpu(NULL);
if (!cpumask_empty(&iucv_irq_cpumask)) if (!cpumask_empty(&iucv_irq_cpumask))
return 0; goto __free_cpumask;
smp_call_function_single(cpumask_first(&iucv_buffer_cpumask), smp_call_function_single(cpumask_first(&iucv_buffer_cpumask),
iucv_allow_cpu, NULL, 1); iucv_allow_cpu, NULL, 1);
return 0;
__free_cpumask:
free_cpumask_var(cpumask);
return ret;
} }
/** /**