TechPanelGM/kernel_xiaomi_sm8250
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

IB/qib: Fix memory leak in qib_user_sdma_queue_pkts()

Browse Source 
[ Upstream commit bee90911e0138c76ee67458ac0d58b38a3190f65 ]

The wrong goto label was used for the error case and missed cleanup of the
pkt allocation.

Fixes: d39bf40e55e6 ("IB/qib: Protect from buffer overflow in struct qib_user_sdma_pkt fields")
Link: https://lore.kernel.org/r/20211208175238.29983-1-jose.exposito89@gmail.com
Addresses-Coverity-ID: 1493352 ("Resource leak")
Signed-off-by: José Expósito <jose.exposito89@gmail.com>
Acked-by: Mike Marciniszyn <mike.marciniszyn@cornelisnetworks.com>
Signed-off-by: Jason Gunthorpe <jgg@nvidia.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
This commit is contained in:
José Expósito
2021-12-08 18:52:38 +01:00
committed by Greg Kroah-Hartman
parent ab381351f9
commit 0aaec9c5f6
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
drivers/infiniband/hw/qib/qib_user_sdma.c
View File

@@ -945,7 +945,7 @@ static int qib_user_sdma_queue_pkts(const struct qib_devdata *dd,
&addrlimit) || &addrlimit) ||
addrlimit > type_max(typeof(pkt->addrlimit))) { addrlimit > type_max(typeof(pkt->addrlimit))) {
ret = -EINVAL; ret = -EINVAL;
goto free_pbc; goto free_pkt;
} }
pkt->addrlimit = addrlimit; pkt->addrlimit = addrlimit;