TechPanelGM/kernel_xiaomi_sm8250
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

mailbox: bcm-pdc: potential NULL dereference in pdc_shutdown()

Browse Source 
We can't pass NULL pointers to pdc_ring_free() so I moved the check for
NULL.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Jassi Brar <jaswinder.singh@linaro.org>
This commit is contained in:
Dan Carpenter
2016-08-04 08:30:31 +03:00
committed by Jassi Brar
parent e0c6fba45a
commit 068cf29eca
1 changed files with 4 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
drivers/mailbox/bcm-pdc-mailbox.c
View File

@@ -1191,10 +1191,11 @@ static void pdc_shutdown(struct mbox_chan *chan)
{ {
struct pdc_state *pdcs = chan->con_priv; struct pdc_state *pdcs = chan->con_priv;
if (pdcs) if (!pdcs)
return;
dev_dbg(&pdcs->pdev->dev, dev_dbg(&pdcs->pdev->dev,
"Shutdown mailbox channel for PDC %u", pdcs->pdc_idx); "Shutdown mailbox channel for PDC %u", pdcs->pdc_idx);
pdc_ring_free(pdcs); pdc_ring_free(pdcs);
} }