TechPanelGM/kernel_xiaomi_sm8250
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

serial: mctrl_gpio: Check for NULL pointer

Browse Source 
[ Upstream commit 37e3ab00e4734acc15d96b2926aab55c894f4d9c ]

When using mctrl_gpio_to_gpiod, it dereferences gpios into a single
requested GPIO.  This dereferencing can break if gpios is NULL,
so this patch adds a NULL check before dereferencing it.  If
gpios is NULL, this function will also return NULL.

Signed-off-by: Adam Ford <aford173@gmail.com>
Reviewed-by: Yegor Yefremov <yegorslists@googlemail.com>
Link: https://lore.kernel.org/r/20191006163314.23191-1-aford173@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
This commit is contained in:
Adam Ford
2019-10-06 11:33:11 -05:00
committed by Greg Kroah-Hartman
parent 497fd98a50
commit 02c1fb11b6
1 changed files with 3 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
drivers/tty/serial/serial_mctrl_gpio.c
View File

@@ -60,6 +60,9 @@ EXPORT_SYMBOL_GPL(mctrl_gpio_set);
struct gpio_desc *mctrl_gpio_to_gpiod(struct mctrl_gpios *gpios, struct gpio_desc *mctrl_gpio_to_gpiod(struct mctrl_gpios *gpios,
enum mctrl_gpio_idx gidx) enum mctrl_gpio_idx gidx)
{ {
if (gpios == NULL)
return NULL;
return gpios->gpio[gidx]; return gpios->gpio[gidx];
} }
EXPORT_SYMBOL_GPL(mctrl_gpio_to_gpiod); EXPORT_SYMBOL_GPL(mctrl_gpio_to_gpiod);