TechPanelGM/kernel_xiaomi_sm8250
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

coresight: tmc-etr: fix etr smmu unmap issue

Browse Source 
The return value 0 of dma_map_resource() is valid, so should use
the dma_mapping_error() to check for errors.

Change-Id: I368f480ed66bad0498e38da2fc6baa78b5935d7f
Signed-off-by: Yuanfang Zhang <zhangyuanfang@codeaurora.org>
This commit is contained in:
Yuanfang Zhang
2020-04-22 16:04:21 +08:00
parent 4945d76d49
commit 014fc527b8
1 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
drivers/hwtracing/coresight/coresight-tmc-etr.c
View File

@@ -1162,7 +1162,7 @@ static int tmc_etr_fill_usb_bam_data(struct tmc_drvdata *drvdata)
data_fifo_iova = dma_map_resource(drvdata->dev, data_fifo_iova = dma_map_resource(drvdata->dev,
bamdata->data_fifo.phys_base, bamdata->data_fifo.size, bamdata->data_fifo.phys_base, bamdata->data_fifo.size,
DMA_BIDIRECTIONAL, 0); DMA_BIDIRECTIONAL, 0);
if (!data_fifo_iova) if (dma_mapping_error(drvdata->dev, data_fifo_iova))
return -ENOMEM; return -ENOMEM;
dev_dbg(drvdata->dev, "%s:data p_addr:%pa,iova:%pad,size:%x\n", dev_dbg(drvdata->dev, "%s:data p_addr:%pa,iova:%pad,size:%x\n",
__func__, &(bamdata->data_fifo.phys_base), __func__, &(bamdata->data_fifo.phys_base),
@@ -1171,7 +1171,7 @@ static int tmc_etr_fill_usb_bam_data(struct tmc_drvdata *drvdata)
desc_fifo_iova = dma_map_resource(drvdata->dev, desc_fifo_iova = dma_map_resource(drvdata->dev,
bamdata->desc_fifo.phys_base, bamdata->desc_fifo.size, bamdata->desc_fifo.phys_base, bamdata->desc_fifo.size,
DMA_BIDIRECTIONAL, 0); DMA_BIDIRECTIONAL, 0);
if (!desc_fifo_iova) if (dma_mapping_error(drvdata->dev, desc_fifo_iova))
return -ENOMEM; return -ENOMEM;
dev_dbg(drvdata->dev, "%s:desc p_addr:%pa,iova:%pad,size:%x\n", dev_dbg(drvdata->dev, "%s:desc p_addr:%pa,iova:%pad,size:%x\n",
__func__, &(bamdata->desc_fifo.phys_base), __func__, &(bamdata->desc_fifo.phys_base),
@@ -1243,7 +1243,7 @@ static int get_usb_bam_iova(struct device *dev, unsigned long usb_bam_handle,
return ret; return ret;
} }
*iova = dma_map_resource(dev, p_addr, bam_size, DMA_BIDIRECTIONAL, 0); *iova = dma_map_resource(dev, p_addr, bam_size, DMA_BIDIRECTIONAL, 0);
if (!(*iova)) if (dma_mapping_error(dev, *iova))
return -ENOMEM; return -ENOMEM;
return 0; return 0;
} }